Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753282AbcLNSyF (ORCPT ); Wed, 14 Dec 2016 13:54:05 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:33425 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbcLNSyD (ORCPT ); Wed, 14 Dec 2016 13:54:03 -0500 Subject: Re: [v2] net:ethernet:cavium:octeon:octeon_mgmt: Handle return NULL error from devm_ioremap To: arvind Yadav References: <1481732732-6892-1-git-send-email-arvind.yadav.cs@gmail.com> <3c3d5968-bc41-e1b7-6fda-78e92e7a9d56@caviumnetworks.com> <0be48286-2656-84b4-4cd8-93bea5fbc6f0@gmail.com> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Florian Fainelli Message-ID: <262b3fdb-754b-a1f1-bd6a-3b15d72063b4@gmail.com> Date: Wed, 14 Dec 2016 10:54:00 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1225 Lines: 31 On 12/14/2016 10:39 AM, arvind Yadav wrote: > Hi David, > > I have gave my comment. > > Thanks > Arvind > > On Wednesday 14 December 2016 11:44 PM, David Daney wrote: >> On 12/14/2016 10:06 AM, arvind Yadav wrote: >>> Yes, I have seen this error. We have a device with very less memory. >>> Basically it's OMAP2 board. We have to port Android L on this. >>> It's has 3.10 kernel version. In this device, we were getting Page >>> allocation failure. >> >> This makes absolutely no sense to me. OCTEON is a mips64 SoC with a >> ton of memory where ioremap can never fail, and it doesn't run >> Android, and you are talking about OMAP2. > -I just gave as example where i have seen ioremap issue. > Please don't relate. I know, Now it will not fail. ioremap will through > NULL on failure. We should catch this error. Even other driver of MIPS > soc is having same check. It's just check which will not impact any > functionality or performance of this driver. It will avoid NULL pointer > error. We know, if function is returning any error. we should catch. Your patch subject should also be changed to insert spaces between semicolon, so this would be: net: ethernet: cavium: octeon: octeon_mgmt: -- Florian