Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756285AbcLNTNU (ORCPT ); Wed, 14 Dec 2016 14:13:20 -0500 Received: from mail-co1nam03on0099.outbound.protection.outlook.com ([104.47.40.99]:44583 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756172AbcLNTNR (ORCPT ); Wed, 14 Dec 2016 14:13:17 -0500 X-Greylist: delayed 887 seconds by postgrey-1.27 at vger.kernel.org; Wed, 14 Dec 2016 14:13:16 EST From: Hartley Sweeten To: Florian Fainelli , Moritz Fischer CC: Linux Kernel Mailing List , linux-arm-kernel , Alan Tull , Russell King , "rmallon@gmail.com" , "linux-fpga@vger.kernel.org" Subject: RE: [PATCH v3 2/2] FPGA: Add TS-7300 FPGA manager Thread-Topic: [PATCH v3 2/2] FPGA: Add TS-7300 FPGA manager Thread-Index: AQHSVbLRHISBKvdE1E2PBCvqKhA92KEG9WYAgADWcAD////u8A== Date: Wed, 14 Dec 2016 18:58:05 +0000 Message-ID: References: <20161214023553.9377-1-f.fainelli@gmail.com> <20161214023553.9377-3-f.fainelli@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=HartleyS@visionengravers.com; x-originating-ip: [184.183.19.121] x-ms-office365-filtering-correlation-id: 152cf427-a227-4e49-24a4-08d42453231a x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:SN1PR0101MB1568; x-microsoft-exchange-diagnostics: 1;SN1PR0101MB1568;7:VO/LOSy75ntUW2mS2oIgfpSccwEk0X/mjqR1FeI8AAexjUfvvXFEUO36FMnkfAR2xeq2xUBN12v02Mwf1tATM8QWC0LqvhbZH2DiI5DC//e73q4qWNMFI/2ecsWLKpyUjAp/y8em0wPs4ZQtfqdnATR9dWn20mfSuFbNGLFLU6lOPIZ3uFQzKnEJnEGVBtuDoEPwZ6zyu6kJwwOJZ0XSB5J4MlWlltWoPTPlbvuBir2e6SC/iTPMJ4WaqPn6dIRc66A+2+8UGet7Bvoq5qoJMvTFAVA9Nq28BCIr2lJLUW9MtbX6NbKdWGUbqDz/rJTUeiI/vM1v0tF9LWpwmY3AGagXbX9ljzDBroI7DJYa+YZ1JKVFNac/8APxeqjM4chl2ZvtxIs1A0rFJu3DKGdQGhvPu8t9/TTUkt43YX5Q8leloUsHULtbhPG+HupcbWP+pScaiOYR5A9A2y07Wp6HfQ== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(2016111802025)(20161123555025)(20161123560025)(20161123562025)(20161123564025)(6043046)(6072148);SRVR:SN1PR0101MB1568;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0101MB1568; x-forefront-prvs: 01565FED4C x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(39840400002)(39410400002)(39450400003)(377454003)(24454002)(199003)(189002)(68736007)(3660700001)(6436002)(77096006)(229853002)(2906002)(80792005)(86362001)(106116001)(38730400001)(9686002)(6506006)(105586002)(106356001)(122556002)(81166006)(25786008)(5660300001)(2950100002)(39060400001)(8676002)(81156014)(92566002)(8936002)(3280700002)(5001770100001)(189998001)(97736004)(7696004)(101416001)(3846002)(50986999)(76176999)(54356999)(6116002)(2900100001)(93886004)(305945005)(66066001)(7736002)(74316002)(33656002)(102836003)(4326007);DIR:OUT;SFP:1102;SCL:1;SRVR:SN1PR0101MB1568;H:SN1PR0101MB1565.prod.exchangelabs.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: visionengravers.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2016 18:58:05.4462 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d698601f-af92-4269-8099-fd6f11636477 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0101MB1568 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id uBEJDOtQ013238 Content-Length: 550 Lines: 14 On Wednesday, December 14, 2016 11:55 AM, Florian Fainelli wrote: > My understanding is that, yes, this triggers the final write. You are > right that ts73xx_fpga_write() can be called multiple times. It sounds > like what my write_complete function does right now is just return that > we successfully completed the bistream write, but this snippet that you > are quoting should actually be moved into write_complete. Florian, I'm in the process of getting a TS-7300 board so I can help test this. Hopefully I will have it by next week. Hartley