Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932410AbcLNTNi (ORCPT ); Wed, 14 Dec 2016 14:13:38 -0500 Received: from mail.kernel.org ([198.145.29.136]:45268 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756360AbcLNTNd (ORCPT ); Wed, 14 Dec 2016 14:13:33 -0500 Date: Wed, 14 Dec 2016 16:13:20 -0300 From: "acme@kernel.org" To: "Liang, Kan" Cc: Jiri Olsa , "linux-kernel@vger.kernel.org" , "mingo@redhat.com" , "peterz@infradead.org" , "jolsa@kernel.org" , "Hunter, Adrian" , "andi@firstfloor.org" Subject: Re: [PATCH] perf tools: ignore zombie process for user profile Message-ID: <20161214191320.GA6866@kernel.org> References: <1481737685-24595-1-git-send-email-kan.liang@intel.com> <20161214175911.GA14085@krava> <37D7C6CF3E00A74B8858931C1DB2F0775367F8F6@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F0775367F8F6@SHSMSX103.ccr.corp.intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 909 Lines: 24 Em Wed, Dec 14, 2016 at 06:26:02PM +0000, Liang, Kan escreveu: > > On Wed, Dec 14, 2016 at 12:48:05PM -0500, kan.liang@intel.com wrote: > > > From: Kan Liang > > > Zombie process is dead process. It is meaningless to profile it. > > > It's better to ignore it for user profile. > > I recently posted different patch for same issue: > > http://marc.info/?l=linux-kernel&m=148153895827359&w=2 > The change as below make me confuse. > + /* The system wide setup does not work with threads. */ > + if (!evsel->system_wide) > + return false; > It looks the meaning of the comments is inconsistent with the code. > Your original patch doesn't work well with the issue. > But if I change the above code as below, the issue is fixed. > if (evsel->system_wide) > return false; yeah, Namhyung noticed that, Jiri sent a fixed patch, I have it already in my perf/core branch. - Arnaldo