Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754259AbcLNTT5 convert rfc822-to-8bit (ORCPT ); Wed, 14 Dec 2016 14:19:57 -0500 Received: from mga11.intel.com ([192.55.52.93]:58323 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751022AbcLNTT4 (ORCPT ); Wed, 14 Dec 2016 14:19:56 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,347,1477983600"; d="scan'208";a="39995200" From: "Liang, Kan" To: "acme@kernel.org" CC: Jiri Olsa , "linux-kernel@vger.kernel.org" , "mingo@redhat.com" , "peterz@infradead.org" , "jolsa@kernel.org" , "Hunter, Adrian" , "andi@firstfloor.org" Subject: RE: [PATCH] perf tools: ignore zombie process for user profile Thread-Topic: [PATCH] perf tools: ignore zombie process for user profile Thread-Index: AQHSVjJnKH4edSLBtkyuCZ3KM60fFaEHNQqAgACK/WD//4m7AIAAhx6w Date: Wed, 14 Dec 2016 19:19:51 +0000 Message-ID: <37D7C6CF3E00A74B8858931C1DB2F0775367F92B@SHSMSX103.ccr.corp.intel.com> References: <1481737685-24595-1-git-send-email-kan.liang@intel.com> <20161214175911.GA14085@krava> <37D7C6CF3E00A74B8858931C1DB2F0775367F8F6@SHSMSX103.ccr.corp.intel.com> <20161214191320.GA6866@kernel.org> In-Reply-To: <20161214191320.GA6866@kernel.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjFiNDE3ODktYTExMS00OTZjLWI4MjktNmI4MGUwYmIxNDMwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Im41bkxuZktOUk5IU2x0T2tcL1l5K1EwYW5xOVdzbUppbXBSMzhwYm9XRU9ZPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1042 Lines: 32 . > Em Wed, Dec 14, 2016 at 06:26:02PM +0000, Liang, Kan escreveu: > > > On Wed, Dec 14, 2016 at 12:48:05PM -0500, kan.liang@intel.com wrote: > > > > From: Kan Liang Zombie process is dead > > > > process. It is meaningless to profile it. > > > > It's better to ignore it for user profile. > > > > I recently posted different patch for same issue: > > > http://marc.info/?l=linux-kernel&m=148153895827359&w=2 > > > The change as below make me confuse. > > + /* The system wide setup does not work with threads. */ > > + if (!evsel->system_wide) > > + return false; > > It looks the meaning of the comments is inconsistent with the code. > > > Your original patch doesn't work well with the issue. > > But if I change the above code as below, the issue is fixed. > > if (evsel->system_wide) > > return false; > > yeah, Namhyung noticed that, Jiri sent a fixed patch, I have it already in my > perf/core branch. > That's great. Then Jiri's patch would work on my case. Please ignore this patch. Thanks, Kan