User-Agent: K-9 Mail for Android
In-Reply-To: <tip-ec2d86a9b646d93f1948569f368e2c6f5449e6c7@git.kernel.org>
References: <4d8a1952759721d42d1e62ba9e4a7e3ac5df8574.1481685203.git.jpoimboe@redhat.com> <tip-ec2d86a9b646d93f1948569f368e2c6f5449e6c7@git.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain;
 charset=UTF-8
Subject: Re: [tip:x86/urgent] x86/boot/64: Use 'push' instead of 'call' in start_cpu()
From: hpa@zytor.com
Date: Wed, 14 Dec 2016 11:24:19 -0800
To: linux-tip-commits@vger.kernel.org,
        tip-bot for Josh Poimboeuf <tipbot@zytor.com>
CC: linux-kernel@vger.kernel.org, bp@alien8.de, tglx@linutronix.de,
        torvalds@linux-foundation.org, peterz@infradead.org, luto@kernel.org,
        jpoimboe@redhat.com, mingo@kernel.org, brgerst@gmail.com,
        dvlasenk@redhat.com
Message-ID: <50553B60-057F-46E4-BB93-ADCE7B5F821D@zytor.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2033
Lines: 50

On December 14, 2016 12:36:58 AM PST, tip-bot for Josh Poimboeuf <tipbot@zytor.com> wrote:
>Commit-ID:  ec2d86a9b646d93f1948569f368e2c6f5449e6c7
>Gitweb:    
>http://git.kernel.org/tip/ec2d86a9b646d93f1948569f368e2c6f5449e6c7
>Author:     Josh Poimboeuf <jpoimboe@redhat.com>
>AuthorDate: Tue, 13 Dec 2016 21:25:35 -0600
>Committer:  Ingo Molnar <mingo@kernel.org>
>CommitDate: Wed, 14 Dec 2016 08:48:05 +0100
>
>x86/boot/64: Use 'push' instead of 'call' in start_cpu()
>
>start_cpu() pushes a text address on the stack so that stack traces
>from
>idle tasks will show start_cpu() at the end.  But it uses a call
>instruction to do that, which is rather obtuse.  Use a straightforward
>push instead.
>
>Suggested-by: Borislav Petkov <bp@alien8.de>
>Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
>Cc: Andy Lutomirski <luto@kernel.org>
>Cc: Brian Gerst <brgerst@gmail.com>
>Cc: Denys Vlasenko <dvlasenk@redhat.com>
>Cc: H. Peter Anvin <hpa@zytor.com>
>Cc: Linus Torvalds <torvalds@linux-foundation.org>
>Cc: Peter Zijlstra <peterz@infradead.org>
>Cc: Thomas Gleixner <tglx@linutronix.de>
>Link:
>http://lkml.kernel.org/r/4d8a1952759721d42d1e62ba9e4a7e3ac5df8574.1481685203.git.jpoimboe@redhat.com
>Signed-off-by: Ingo Molnar <mingo@kernel.org>
>---
> arch/x86/kernel/head_64.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/arch/x86/kernel/head_64.S b/arch/x86/kernel/head_64.S
>index 90de288..1facaf4 100644
>--- a/arch/x86/kernel/head_64.S
>+++ b/arch/x86/kernel/head_64.S
>@@ -298,7 +298,7 @@ ENTRY(start_cpu)
> 	 *	REX.W + FF /5 JMP m16:64 Jump far, absolute indirect,
> 	 *		address given in m16:64.
> 	 */
>-	call	1f		# put return address on stack for unwinder
>+	pushq	$1f		# put return address on stack for unwinder
> 1:	xorq	%rbp, %rbp	# clear frame pointer
> 	movq	initial_code(%rip), %rax
> 	pushq	$__KERNEL_CS	# set correct cs

This adds another relocation to the kernel.  I hope this is safe at this point in the code?
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.