Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754111AbcLNTzj (ORCPT ); Wed, 14 Dec 2016 14:55:39 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:44834 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752417AbcLNTzh (ORCPT ); Wed, 14 Dec 2016 14:55:37 -0500 From: Laurent Pinchart To: Ramiro Oliveira Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, vinod.koul@intel.com, robh+dt@kernel.org, mark.rutland@arm.com, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, appana.durga.rao@xilinx.com, anuragku@xilinx.com, dan.j.williams@intel.com, CARLOS.PALMINHA@synopsys.com Subject: Re: [PATCH 1/2] xilinx_dma: Edit device tree bindings documentation Date: Wed, 14 Dec 2016 21:56:10 +0200 Message-ID: <12776575.5mdqB62qf1@avalon> User-Agent: KMail/4.14.10 (Linux/4.8.6-gentoo; KDE/4.14.24; x86_64; ; ) In-Reply-To: <78b8d3b8540a2310818cf0c5b05adbc29e067981.1481735244.git.roliveir@synopsys.com> References: <78b8d3b8540a2310818cf0c5b05adbc29e067981.1481735244.git.roliveir@synopsys.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1597 Lines: 45 Hi Ramiro, Thank you for the patch. On Wednesday 14 Dec 2016 17:18:23 Ramiro Oliveira wrote: > Add reset property documentation for Xilinx DMA > > Signed-off-by: Ramiro Oliveira > --- > Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt index > a2b8bfa..7ebce72 100644 > --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt > +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt > @@ -40,6 +40,10 @@ Required properties for VDMA: > Optional properties: > - xlnx,include-sg: Tells configured for Scatter-mode in > the hardware. > +- resets : Must contain an entry for each entry in reset-names. > + See ../reset/reset.txt for details. > +- reset-names : Must include the following entries: > + - reset If the IP core has a single reset, can't we omit the name ? > Optional properties for AXI DMA: > - xlnx,mcdma: Tells whether configured for multi-channel mode in the > hardware. Optional properties for VDMA: > @@ -83,6 +87,8 @@ axi_vdma_0: axivdma@40030000 { > clocks = <&clk 0>, <&clk 1>, <&clk 2>, <&clk 3>, <&clk 4>; > clock-names = "s_axi_lite_aclk", "m_axi_mm2s_aclk", "m_axi_s2mm_aclk", > "m_axis_mm2s_aclk", "s_axis_s2mm_aclk"; > + resets = <&rst 2>; > + reset-names = "reset"; > dma-channel@40030000 { > compatible = "xlnx,axi-vdma-mm2s-channel"; > interrupts = < 0 54 4 >; -- Regards, Laurent Pinchart