Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756878AbcLNV1x convert rfc822-to-8bit (ORCPT ); Wed, 14 Dec 2016 16:27:53 -0500 Received: from mga06.intel.com ([134.134.136.31]:8808 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753847AbcLNV1v (ORCPT ); Wed, 14 Dec 2016 16:27:51 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,348,1477983600"; d="scan'208";a="42587255" From: "Dilger, Andreas" To: Tabrez khan CC: "jsimmons@infradead.org" , "gregkh@linuxfoundation.org" , "lustre-devel@lists.lustre.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] staging : osc : coding style fix Thread-Topic: [PATCH] staging : osc : coding style fix Thread-Index: AQHSVk6tPiroA/4KnUefmwu/qNMOu6EIe1CA Date: Wed, 14 Dec 2016 21:27:49 +0000 Message-ID: <96EAFB90-2162-4155-950D-F586EE1DAF87@intel.com> References: <1481749884-25674-1-git-send-email-khan.tabrez21@gmail.com> In-Reply-To: <1481749884-25674-1-git-send-email-khan.tabrez21@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.103.237] Content-Type: text/plain; charset="us-ascii" Content-ID: <75AE5CE56D37354DAA85116F11E7C77E@intel.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1929 Lines: 60 On Dec 14, 2016, at 14:11, Tabrez khan wrote: > > Subject: [PATCH] staging : osc : coding style fix Thanks for sumbitting your patch. As a general rule, the patch summary line should try to describe (as best as possible in a single line) what the patch is actually fixing. It is true this is a "coding style fix" but there are many possible style fixes and it is better to be as specific as space allows. Something like: staging/lustre/osc: remove unnecessary braces or staging/lustre/osc: remove braces from single-line body or staging/lustre/osc: remove braces in osc_release_write_grant() would be more specific. This is doubly important if you are making a large number of similar patches, since it is desirable to have a (relatively) unique summary line for each patch to avoid confusion. > Remove unnecessary braces {} for single if statement block. > This warning is found using checkpatch.pl. The commit body is good. Please resubmit with a new summary line, then you can include: Reviewed-by: Andreas Dilger Cheers, Andreas > Signed-off-by: Tabrez khan > --- > drivers/staging/lustre/lustre/osc/osc_cache.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/osc/osc_cache.c b/drivers/staging/lustre/lustre/osc/osc_cache.c > index 4bbe219..5ded31a 100644 > --- a/drivers/staging/lustre/lustre/osc/osc_cache.c > +++ b/drivers/staging/lustre/lustre/osc/osc_cache.c > @@ -1420,10 +1420,8 @@ static void osc_release_write_grant(struct client_obd *cli, > struct brw_page *pga) > { > assert_spin_locked(&cli->cl_loi_list_lock); > - if (!(pga->flag & OBD_BRW_FROM_GRANT)) { > + if (!(pga->flag & OBD_BRW_FROM_GRANT)) > return; > - } > - > pga->flag &= ~OBD_BRW_FROM_GRANT; > atomic_long_dec(&obd_dirty_pages); > cli->cl_dirty_pages--; > -- > 2.7.4 >