Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933861AbcLNWXH (ORCPT ); Wed, 14 Dec 2016 17:23:07 -0500 Received: from mail-io0-f195.google.com ([209.85.223.195]:33648 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933470AbcLNWXD (ORCPT ); Wed, 14 Dec 2016 17:23:03 -0500 MIME-Version: 1.0 X-Originating-IP: [181.121.136.80] In-Reply-To: <1481749963-8664-1-git-send-email-pali.rohar@gmail.com> References: <1481749963-8664-1-git-send-email-pali.rohar@gmail.com> From: Javier Martinez Canillas Date: Wed, 14 Dec 2016 19:22:46 -0300 Message-ID: Subject: Re: [PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE in case DT does not provide /chosen/bootargs To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Russell King , Arnd Bergmann , Robin Murphy , Linus Walleij , Ben Dooks , Tony Lindgren , Ivaylo Dimitrov , Sebastian Reichel , Aaro Koskinen , Pavel Machek , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uBEMNFG0005889 Content-Length: 1046 Lines: 27 Hello Pali, On Wed, Dec 14, 2016 at 6:12 PM, Pali Rohár wrote: > Commit 008a2ebcd677 ("ARM: dts: omap3: Remove skeleton.dtsi usage") broke > support for setting cmdline on Nokia N900 via CONFIG_CMDLINE. > This commit really exposed the issue rather than causing it. But since it was working before due including skeleton.dtsi which defines an empty chosen node, I think that you should add a: Fixes: 008a2ebcd677 ("ARM: dts: omap3: Remove skeleton.dtsi usage") > It is because arm code booted in DT mode parse cmdline only via function > early_init_dt_scan_chosen() and that function does not fill variable > boot_command_line when DTB does not contain /chosen entry. It is called > from function early_init_dt_scan_nodes() in setup_machine_fdt(). > > This patch fixes it by explicitly filling boot_command_line in function > setup_machine_fdt() after calling early_init_dt_scan_nodes() in case > boot_command_line still remains empty. > > Signed-off-by: Pali Rohár > --- Best regards, Javier