Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933974AbcLODU6 (ORCPT ); Wed, 14 Dec 2016 22:20:58 -0500 Received: from mail-pg0-f54.google.com ([74.125.83.54]:32889 "EHLO mail-pg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932109AbcLODU5 (ORCPT ); Wed, 14 Dec 2016 22:20:57 -0500 Date: Wed, 14 Dec 2016 19:20:53 -0800 From: Brian Norris To: Xing Zheng Cc: Doug Anderson , frank.wang@rock-chips.com, "open list:ARM/Rockchip SoC..." , Heiko =?iso-8859-1?Q?St=FCbner?= , William wu , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Caesar Wang , Shawn Lin , Jianqun Xu , Elaine Zhang , David Wu , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Dmitry Torokhov Subject: Re: [PATCH 3/3] arm64: dts: rockchip: add clk-480m for ehci and ohci of rk3399 Message-ID: <20161215032052.GA116728@google.com> References: <1481710301-1454-1-git-send-email-zhengxing@rock-chips.com> <1481710301-1454-4-git-send-email-zhengxing@rock-chips.com> <5ce521da-119a-2de8-026c-5992fedfef43@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5ce521da-119a-2de8-026c-5992fedfef43@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 753 Lines: 20 On Thu, Dec 15, 2016 at 10:41:04AM +0800, Xing Zheng wrote: > // Frank > > Hi Doug, Brain, > Thanks for the reply. > Sorry I forgot these patches have been sent earlier, and Frank > have some explained and discussed with Heiko. > Please see https://patchwork.kernel.org/patch/9255245/ > Perhaps we can move to that patch tree to continue the discussion. > > I think Frank and William will help us to continue checking these. I only briefly read that discussion, but AFAICT it doesn't actually address all the comments/quetions we had here. For instance, the power_off() vs. delayed-work race in your USB2 PHY driver (is that intentional?). Also, the question of why PHY (auto?)suspend is relevant. I'll check again tomorrow. Brian