Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754900AbcLODaj (ORCPT ); Wed, 14 Dec 2016 22:30:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54914 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752884AbcLODah (ORCPT ); Wed, 14 Dec 2016 22:30:37 -0500 From: Xunlei Pang To: kexec@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Xunlei Pang , Robert LeBlanc , Baoquan He Subject: [PATCH] x86/crash: Update the stale comment in reserve_crashkernel() Date: Thu, 15 Dec 2016 11:30:21 +0800 Message-Id: <1481772621-17923-1-git-send-email-xlpang@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 15 Dec 2016 03:30:37 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 977 Lines: 28 CRASH_KERNEL_ADDR_MAX was missing for a long time, update it with more detailed explanation. Cc: Robert LeBlanc Cc: Baoquan He Signed-off-by: Xunlei Pang --- arch/x86/kernel/setup.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c index 9c337b0..79ee507 100644 --- a/arch/x86/kernel/setup.c +++ b/arch/x86/kernel/setup.c @@ -575,7 +575,10 @@ static void __init reserve_crashkernel(void) /* 0 means: find the address automatically */ if (crash_base <= 0) { /* - * kexec want bzImage is below CRASH_KERNEL_ADDR_MAX + * Set CRASH_ADDR_LOW_MAX upper bound for crash range + * as old kexec-tools loads bzImage below that, unless + * "size,high" or "size@offset"(nonzero offset, see the + * else leg below) is specified. */ crash_base = memblock_find_in_range(CRASH_ALIGN, high ? CRASH_ADDR_HIGH_MAX -- 1.8.3.1