Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757153AbcLOHJU (ORCPT ); Thu, 15 Dec 2016 02:09:20 -0500 Received: from mail-vk0-f66.google.com ([209.85.213.66]:34804 "EHLO mail-vk0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755229AbcLOHJS (ORCPT ); Thu, 15 Dec 2016 02:09:18 -0500 MIME-Version: 1.0 In-Reply-To: <20161214210935.GA135941@google.com> References: <984fd8eb53b742bd46e7b42605ae4e0ceaf5ba08.1474450295.git.dwalter@sigma-star.at> <20160921121531.7786ee9b@bbrezillon> <20160928201611.GB142302@google.com> <20161214210935.GA135941@google.com> From: Karl Beldan Date: Thu, 15 Dec 2016 07:09:10 +0000 Message-ID: Subject: Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device() To: Brian Norris Cc: Boris Brezillon , Richard Weinberger , "linux-mtd@lists.infradead.org" , David Woodhouse , "linux-kernel@vger.kernel.org" , Daniel Walter , Stable Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1675 Lines: 48 On Wed, Dec 14, 2016 at 9:09 PM, Brian Norris wrote: > On Wed, Dec 14, 2016 at 07:24:46PM +0000, Karl Beldan wrote: >> On Wed, Sep 28, 2016 at 8:16 PM, Brian Norris >> wrote: >> > On Wed, Sep 21, 2016 at 12:15:31PM +0200, Boris Brezillon wrote: >> >> On Wed, 21 Sep 2016 11:43:56 +0200 >> >> Daniel Walter wrote: >> >> >> >> > From: Richard Weinberger >> >> > >> >> > If the master device has callbacks for _get/put_device() >> >> > and this MTD has slaves a get_mtd_device() call on paritions >> >> > will never issue the registered callbacks. >> >> > Fix this by propagating _get/put_device() down. >> >> >> >> Brian, can we have this one queued for 4.9? I can't take it in my tree >> >> if you want, but it's probably better if it's in the mtd tree. >> > >> > Applied this patch to l2-mtd.git >> > >> >> I think this should also go into -stable. > > Why? Do you have real use cases that are broken by this? I understand I do, some code adding partitions on a gluebi master. > this is a problem, but I'm curious on how this satisfies the stable > rules. > > Also, note that this isn't a regression; it's been broken forever and > apparently no one noticed. IMO that raises the bar a bit (but not > impossibly so) for -stable. > I just encountered the bug yesterday and yes it is obvious it has been broken forever. I don't have strong opinion about these things so no worries. Karl > Anyway, if we decide to do this, you'll also want to include the git > hash and applicable kernel versions, per Option 2 [1]. > > Brian > > [1] Documentation/stable_kernel_rules.txt.