Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935598AbcLOJGR (ORCPT ); Thu, 15 Dec 2016 04:06:17 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:56191 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934727AbcLOJGN (ORCPT ); Thu, 15 Dec 2016 04:06:13 -0500 Date: Thu, 15 Dec 2016 00:45:53 -0800 From: Christoph Hellwig To: Damien Le Moal Cc: Christoph Hellwig , Stefan Haberland , axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, hoeppner@linux.vnet.ibm.com, sebott@linux.vnet.ibm.com Subject: Re: [RFC] block: check partition alignment Message-ID: <20161215084553.GA19716@infradead.org> References: <20161214164706.45543-1-sth@linux.vnet.ibm.com> <20161214170719.GA3599@infradead.org> <5824c17b-a7d7-60a1-6bb7-287257aaf67a@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5824c17b-a7d7-60a1-6bb7-287257aaf67a@wdc.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 438 Lines: 8 On Thu, Dec 15, 2016 at 10:33:47AM +0900, Damien Le Moal wrote: > For a regular block device, I agree. But in Stephan case, I think that > the check really needs to be against the physical block size, with the > added condition that the bdev is a DASD device (similarly to the zone > alignment check for zoned block devices). Then they need to expose a chunk_size. physical block size is defined as not having a meaning for the kernel.