Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935677AbcLOJIo (ORCPT ); Thu, 15 Dec 2016 04:08:44 -0500 Received: from mail-it0-f48.google.com ([209.85.214.48]:38631 "EHLO mail-it0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935526AbcLOJIk (ORCPT ); Thu, 15 Dec 2016 04:08:40 -0500 MIME-Version: 1.0 In-Reply-To: <1481692473-18755-1-git-send-email-bibby.hsieh@mediatek.com> References: <1481692473-18755-1-git-send-email-bibby.hsieh@mediatek.com> From: Daniel Kurtz Date: Thu, 15 Dec 2016 17:08:19 +0800 X-Google-Sender-Auth: TCQ-aeIk6llxQEi_29oXDzp_YkA Message-ID: Subject: Re: [PATCH] drm/mediatek: Support UYVY and YUYV format for overlay To: Bibby Hsieh Cc: David Airlie , Matthias Brugger , Daniel Vetter , dri-devel , "moderated list:ARM/Mediatek SoC support" , Yingjoe Chen , Cawa Cheng , Philipp Zabel , YT Shen , Thierry Reding , CK Hu , Mao Huang , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Sascha Hauer Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2012 Lines: 65 Hi Bibby, On Wed, Dec 14, 2016 at 1:14 PM, Bibby Hsieh wrote: > > MT8173 overlay can support UYVY and YUYV format, > we add the format in DRM driver. > > Signed-off-by: Bibby Hsieh > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 6 ++++++ > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 2 ++ > 2 files changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > index 019b7ca..0a340f3 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > @@ -44,6 +44,8 @@ > #define OVL_CON_CLRFMT_RGB888 (1 << 12) > #define OVL_CON_CLRFMT_RGBA8888 (2 << 12) > #define OVL_CON_CLRFMT_ARGB8888 (3 << 12) > +#define OVL_CON_CLRFMT_UYVY (4 << 12) > +#define OVL_CON_CLRFMT_YUYV (5 << 12) > #define OVL_CON_AEN BIT(8) > #define OVL_CON_ALPHA 0xff > > @@ -161,6 +163,10 @@ static unsigned int ovl_fmt_convert(unsigned int fmt) > case DRM_FORMAT_XBGR8888: > case DRM_FORMAT_ABGR8888: > return OVL_CON_CLRFMT_RGBA8888 | OVL_CON_BYTE_SWAP; > + case DRM_FORMAT_YUYV: > + return OVL_CON_CLRFMT_YUYV; > + case DRM_FORMAT_UYVY: > + return OVL_CON_CLRFMT_UYVY; nit: probably better to alphabetize these (UYVY before YUVU). > } > } > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > index c461a23..b94c6ee 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > @@ -28,6 +28,8 @@ > DRM_FORMAT_XRGB8888, > DRM_FORMAT_ARGB8888, > DRM_FORMAT_RGB565, > + DRM_FORMAT_YUYV, > + DRM_FORMAT_UYVY, nit: probably better to alphabetize these. Other than that, Reviewed-by: Daniel Kurtz > > }; > > static void mtk_plane_reset(struct drm_plane *plane) > -- > 1.9.1 >