Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757725AbcLOJmh (ORCPT ); Thu, 15 Dec 2016 04:42:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48326 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755158AbcLOJmb (ORCPT ); Thu, 15 Dec 2016 04:42:31 -0500 Subject: Re: [PATCH] vfio-mdev: Fix mtty sample driver building To: Alex Williamson References: <20161214193859.32293.43760.stgit@gimli.home> Cc: kwankhede@nvidia.com, cjia@nvidia.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org From: Auger Eric Message-ID: Date: Thu, 15 Dec 2016 10:36:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161214193859.32293.43760.stgit@gimli.home> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 15 Dec 2016 09:36:05 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2247 Lines: 76 Hi, On 14/12/2016 20:39, Alex Williamson wrote: > This sample driver was originally under Documentation/ and was moved > to samples, but build support was never adjusted for the new location. > > Signed-off-by: Alex Williamson > --- > samples/Kconfig | 7 +++++++ > samples/Makefile | 3 ++- > samples/vfio-mdev/Makefile | 14 +------------- > 3 files changed, 10 insertions(+), 14 deletions(-) > > diff --git a/samples/Kconfig b/samples/Kconfig > index a6d2a43..b124f62 100644 > --- a/samples/Kconfig > +++ b/samples/Kconfig > @@ -105,4 +105,11 @@ config SAMPLE_BLACKFIN_GPTIMERS > help > Build samples of blackfin gptimers sample module. > > +config SAMPLE_VFIO_MDEV_MTTY > + tristate "Build VFIO mtty example mediated device sample code -- loadable modules only" > + depends on VFIO_MDEV_DEVICE && m > + help > + Build a virtual tty sample driver for use as a VFIO > + mediated device > + > endif # SAMPLES > diff --git a/samples/Makefile b/samples/Makefile > index e17d66d..86a137e 100644 > --- a/samples/Makefile > +++ b/samples/Makefile > @@ -2,4 +2,5 @@ > > obj-$(CONFIG_SAMPLES) += kobject/ kprobes/ trace_events/ livepatch/ \ > hw_breakpoint/ kfifo/ kdb/ hidraw/ rpmsg/ seccomp/ \ > - configfs/ connector/ v4l/ trace_printk/ blackfin/ > + configfs/ connector/ v4l/ trace_printk/ blackfin/ \ > + vfio-mdev/ > diff --git a/samples/vfio-mdev/Makefile b/samples/vfio-mdev/Makefile > index a932edb..cbbd868 100644 > --- a/samples/vfio-mdev/Makefile > +++ b/samples/vfio-mdev/Makefile > @@ -1,13 +1 @@ > -# > -# Makefile for mtty.c file > -# > -KERNEL_DIR:=/lib/modules/$(shell uname -r)/build > - > -obj-m:=mtty.o > - > -modules clean modules_install: > - $(MAKE) -C $(KERNEL_DIR) SUBDIRS=$(PWD) $@ > - > -default: modules > - > -module: modules > +obj-$(CONFIG_SAMPLE_VFIO_MDEV_MTTY) += mtty.o Test-compiled on ARM aarch64 Reviewed-by: Eric Auger Tested-by: Eric Auger Best Regards Eric > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >