Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936013AbcLOMBo (ORCPT ); Thu, 15 Dec 2016 07:01:44 -0500 Received: from smtp129.dfw.emailsrvr.com ([67.192.241.129]:33627 "EHLO smtp129.dfw.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935780AbcLOMBj (ORCPT ); Thu, 15 Dec 2016 07:01:39 -0500 X-Greylist: delayed 1002 seconds by postgrey-1.27 at vger.kernel.org; Thu, 15 Dec 2016 07:01:39 EST X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH] drivers: staging: comedi: fix function prototypes To: Hartley Sweeten , Piotr Gregor References: <20161214134208.GA26114@westernst> Cc: "gregkh@linuxfoundation.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" From: Ian Abbott Message-ID: Date: Thu, 15 Dec 2016 11:46:31 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1222 Lines: 31 On 14/12/16 16:14, Hartley Sweeten wrote: > On December 14, 2016 6:42 AM, Piotr Gregor wrote: >> Add names of parameters to function prototypes in comedi PCI. >> Checkpatch reports now no errors. >> >> Signed-off-by: Piotr Gregor >> --- >> drivers/staging/comedi/comedi_pci.h | 18 ++++++++++-------- >> 1 file changed, 10 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/staging/comedi/comedi_pci.h b/drivers/staging/comedi/comedi_pci.h >> index 4005cc9..7dfd892 100644 >> --- a/drivers/staging/comedi/comedi_pci.h >> +++ b/drivers/staging/comedi/comedi_pci.h >> @@ -34,18 +34,20 @@ >> #define PCI_VENDOR_ID_RTD 0x1435 >> #define PCI_VENDOR_ID_HUMUSOFT 0x186c >> >> -struct pci_dev *comedi_to_pci_dev(struct comedi_device *); >> +struct pci_dev *comedi_to_pci_dev(struct comedi_device *dev); > > For the function prototypes I prefer no names for the "pointer" parameters. > > The "struct foo *" declaration is just as clear as "struct foo *bar". Maybe, but checkpatch.pl doesn't agree (not since commit ca0d8929e75ab1f860f61208d46955f280a1b05e anyway)! -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-