Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935946AbcLOMBn (ORCPT ); Thu, 15 Dec 2016 07:01:43 -0500 Received: from smtp153.dfw.emailsrvr.com ([67.192.241.153]:37086 "EHLO smtp153.dfw.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935781AbcLOMBj (ORCPT ); Thu, 15 Dec 2016 07:01:39 -0500 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH] drivers: staging: comedi: fix function prototypes To: Piotr Gregor References: <20161214134208.GA26114@westernst> Cc: hsweeten@visionengravers.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Ian Abbott Message-ID: Date: Thu, 15 Dec 2016 11:44:54 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161214134208.GA26114@westernst> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2061 Lines: 51 On 14/12/16 13:42, Piotr Gregor wrote: > Add names of parameters to function prototypes in comedi PCI. > Checkpatch reports now no errors. > > Signed-off-by: Piotr Gregor > --- > drivers/staging/comedi/comedi_pci.h | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/comedi/comedi_pci.h b/drivers/staging/comedi/comedi_pci.h > index 4005cc9..7dfd892 100644 > --- a/drivers/staging/comedi/comedi_pci.h > +++ b/drivers/staging/comedi/comedi_pci.h > @@ -34,18 +34,20 @@ > #define PCI_VENDOR_ID_RTD 0x1435 > #define PCI_VENDOR_ID_HUMUSOFT 0x186c > > -struct pci_dev *comedi_to_pci_dev(struct comedi_device *); > +struct pci_dev *comedi_to_pci_dev(struct comedi_device *dev); > > -int comedi_pci_enable(struct comedi_device *); > -void comedi_pci_disable(struct comedi_device *); > -void comedi_pci_detach(struct comedi_device *); > +int comedi_pci_enable(struct comedi_device *dev); > +void comedi_pci_disable(struct comedi_device *dev); > +void comedi_pci_detach(struct comedi_device *dev); > > -int comedi_pci_auto_config(struct pci_dev *, struct comedi_driver *, > +int comedi_pci_auto_config(struct pci_dev *pcidev, struct comedi_driver *driver, > unsigned long context); > -void comedi_pci_auto_unconfig(struct pci_dev *); > +void comedi_pci_auto_unconfig(struct pci_dev *pcidev); > > -int comedi_pci_driver_register(struct comedi_driver *, struct pci_driver *); > -void comedi_pci_driver_unregister(struct comedi_driver *, struct pci_driver *); > +int comedi_pci_driver_register(struct comedi_driver *comedi_driver, > + struct pci_driver *pci_driver); > +void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver, > + struct pci_driver *pci_driver); > > /** > * module_comedi_pci_driver() - Helper macro for registering a comedi PCI driver > Looks good, thanks! Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-