Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757535AbcLOMwA (ORCPT ); Thu, 15 Dec 2016 07:52:00 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:54984 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752673AbcLOMv5 (ORCPT ); Thu, 15 Dec 2016 07:51:57 -0500 X-Greylist: delayed 393 seconds by postgrey-1.27 at vger.kernel.org; Thu, 15 Dec 2016 07:51:57 EST X-ME-Sender: X-Sasl-enc: RRFHQXOSUn5aFV0i6uMQW1w2frXdTLr+Ub7QdI4jNIEv 1481805869 Date: Thu, 15 Dec 2016 10:44:24 -0200 From: Henrique de Moraes Holschuh To: Darren Hart Cc: Lyude , Andy Shevchenko , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, platform-drivers-x86@vger.kernel.org Subject: Re: [PATCH v2] platform/x86: thinkpad_acpi: Initialize local in_tablet_mode and type Message-ID: <20161215124424.GA20905@khazad-dum.debian.net> References: <20161215041424.GA19534@f23x64.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161215041424.GA19534@f23x64.localdomain> X-GPG-Fingerprint1: 4096R/0x0BD9E81139CB4807: C467 A717 507B BAFE D3C1 6092 0BD9 E811 39CB 4807 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1760 Lines: 53 On Wed, 14 Dec 2016, Darren Hart wrote: > linux-next reported in_tablet_mode and type may be used uninitialized > after: > > b31800283868 ("platform/x86: thinkpad_acpi: Move tablet detection into separate function") > > This turns out to be a false positive as the pr_info call cannot be > reached if tp_features.hotkey_tablet (global scope) is 0, and > in_tablet_mode and type are assigned in both places > tp_features.hotkey_tablet is assigned. > > Regardless, to make it explicit and avoid further reports, initialize > in_tablet_mode to 0 and type to "". > > Signed-off-by: Darren Hart > Cc: Lyude > Cc: Henrique de Moraes Holschuh > Cc: Andy Shevchenko Acked-by: Henrique de Moraes Holschuh > --- > Since v1: Initialize type also. > > drivers/platform/x86/thinkpad_acpi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index 69cb0da..c408390 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -3143,8 +3143,8 @@ typedef tpacpi_keymap_entry_t tpacpi_keymap_t[TPACPI_HOTKEY_MAP_LEN]; > > static int hotkey_init_tablet_mode(void) > { > - int in_tablet_mode, res; > - char *type; > + int in_tablet_mode = 0, res; > + char *type = ""; > > if (acpi_evalf(hkey_handle, &res, "MHKG", "qd")) { > /* For X41t, X60t, X61t Tablets... */ > -- > 2.9.3 > > -- Henrique Holschuh "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot