Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936140AbcLOM6m (ORCPT ); Thu, 15 Dec 2016 07:58:42 -0500 Received: from mail-by2nam01on0062.outbound.protection.outlook.com ([104.47.34.62]:44416 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757439AbcLOM6f (ORCPT ); Thu, 15 Dec 2016 07:58:35 -0500 X-Greylist: delayed 168023 seconds by postgrey-1.27 at vger.kernel.org; Thu, 15 Dec 2016 07:58:35 EST Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=George.Cherian@cavium.com; Subject: Re: [PATCH v2 0/3] Add Support for Cavium Cryptographic Accelerarion Unit To: George Cherian , , References: <1481637801-1076-1-git-send-email-george.cherian@cavium.com> CC: , From: George Cherian Message-ID: <58528FBB.1070001@caviumnetworks.com> Date: Thu, 15 Dec 2016 18:12:35 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1481637801-1076-1-git-send-email-george.cherian@cavium.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: MAXPR01CA0023.INDPRD01.PROD.OUTLOOK.COM (10.164.147.30) To CY1PR0701MB1709.namprd07.prod.outlook.com (10.163.21.11) X-MS-Office365-Filtering-Correlation-Id: 393581e2-4874-425e-9db5-08d424e7e4cf X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CY1PR0701MB1709; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1709;3:UNM8dzHtNfk6ZME0/qSBGoNQWHznf/voaaHbFsAiLU+nfi1AI/9Gx0roI0XhAR7GITD0XBxlP2xuq05m71b4eTgga65KmLMCQI1A3i/xJO1iQtRSYJVFjqpZ8lAKFhmV1HLRk8Xdbm56vTX4SEimvxKyohaf2MlKOaXd/enz0O2gu76iwx2Dc8zuquW8cL/tiOL3xi7f31vUaklys/05PG1MsbQ+BquwYyFEmaVkjqK2329gXYaqUh0JbmJfzM1cDv7dGJrG+xLm45zJ9fNOQA== X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1709;25:VuJK4/k9GmH1SVbBM7Up2ZtbKDtQFNNbO9lCPLpPJcZhQSPMoLWvZGQNSg5xIfsCTPcMqN3kjW0zapA3D7RKLeDlYCFrMRlqNIJrXbynYpc9XAHe6zsSz2AHzynh0NiPxAtYRYG3ln9DwsDKqWCDdWwkqH/Br/9c7SzC15H7MIYbrWKHEzKbmBWlKuqYlYsB96M5VSu/ffzNWQATqRJD87kBdanfsgotE87H8eAwHy6NWx0kNoeb6mmX4gOkULb0tX4lRMRnW7j/f6KYSrqORQhOnbNhrsLtuJ09jij2XHDRqHcFRvdYUJ82yTqd9spr4cUKt8CyW/7aWJQXkl8z14xHBCMRhS3l9xdjApzOZtcaNIhCAf/GzaNiIillpY9QuwPRwmnqYYbwrXJOkr6viVoaGn/Gcfqim4hAE2NfxNqb9vFf2DqsFF2+tg3V0wu0swtjjt4v3fBBXa/n7l1mm0WcFj9lPXHFHatg1KqiTEML6ru+ffVkJ0pVtpaPNJCxHVrjpAZPi6ygQEFlS35lemQgjxjUlDUzhWVvyRbk63OB632f1GhC7xeUUu0y4XYo4/MQAXTzxxg/26K0S9do47nv9/SUq/jE96VkTdFh4UuiG4449UCg6r6rredlhRTZQM3L7cr0M/t3YLd+91sBfgrwURKVWgG/AvUH5rZibAHvJ8up/8oovifBHdi77hr1++adMSP5SMF35PJVwcJ5ij91mN0b3N4U93fygz0diDmMA3o69RXCbKUUjG0OrNTixdNUPkqyZp6rsTj3Lbv+eA== X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1709;31:bLuzHXerBQK+nharks/PLzT+JehTG2/XOh6h3Yq/zZfGjekCtXMygbQN+xl7tLRGt6t8hu2iOWWika2OfamXQzHpIRT50/yN2joGoJqqIwgGHGIcN3nOHkK2KMZMdCnil6aBzO95O9ORc74LPPOvOh9czXt1DHHbUA9rVU1wxaTX31JDbi/Xp9voZDl7S+e0BGcNNQ1HI9wvl58LwuknY14SACivtHQgrVsRCE79fYRFYblFdMdypvj0HwumsT20EJOwU7gIipvzDRxy61ZITg==;20:6mIfH+ru6qrFnj+wM8GZcjXfUWl4q86jSJyC7wMBsSz3ZEb9Axyz7RXp2eEMplJ/1RyOY0nQdWvPO8s0comZG0mb52jcu8N9sXouIlytuBfmiLHieEtpL/azgB1zdSY58Rz88DQkohRr9FEknGpSEaL17JsJs+ESwUyBXEHGdfzK3Xcp2cF0o9N5BZE9CHb6fvdrFkHMHr9k5GwZ7OQ+dfETNHYZ+uIlNY3srwTR8Zy85xDchn7wQwFLZWG/TRHFucWDRUAP6ZF3c728G90xtZXnVWbW+LQDm/lp8GPQJn0zUMKM31kJNqeBxnCwGi1NGqrHvNyxwISYj9q8vSzAqCbM4Lf4r4bMM5SeUypkmKU2EjKBx8zrYmxYJ2Q1GfjOFCaQZwVkAYtPl5bZ/Usy591z0wPNDzGaJr39nj3e4zJyCa9Pe5mo8UXwT1wHG9OPM/MIWMtaHxh3wfa3yHA/olm7jLaGdVE0PCKmmojS4EoICLSDjrcJ7Qaa7oSoehB7+6cVsn7uiBK2/7Mk7rRYenXO/ZrYh9be0FBSXAirHY+i6z5+TiTenfW3VQYwArK4Ut6sv+9D3tcZr88YArvWJOEAd+klJUP4JULc5HY0Kjs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(6072148);SRVR:CY1PR0701MB1709;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0701MB1709; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1709;4:nhxRw8ylEwPUB36BX3mE7jXFip/mCPLDNrvwS9t1aFWKKRwvtNdNFvTqV7t8fJgkWVU5pYKRmRBnt615YFHn1kJpV5BLAIhaXvC7SbYtL4RFZ/qlZOjZCUPWaEQyhaK3hwWTquFP8TxuCWKinvKdvHwI+vLEEEBjN8Y1XWb0YDCtfdluNIiKZczCUscCu0W9pZ50+kJhEdNhV7lyVG+NF5CRaZcSETaZM3XxP4vQMUItwB5j0JacKzdV6DLI1LheafnHQ++a90qDqP2gGIxkgUvsSOaKpU6x8g8ajlM65T0D5OaUVIe4hQLdgQ8jpM2LIFHanf/S2rYpJ0bbMEVygyKL8uPYNkxAF9VS+i+MkMYV2lBz2lXn3wFFIzPLmbiEX8wJztHc3QJAGff0874R+csGcbyPkJa6D/3V/DPPhlOMOOMCGNNp/bLB4i/7P129L8PScE+8v+LbMHlnnAVn0u4w/e5ykw9ZVY1192ld8b8bWbCh6qbs0WlA0NM17hD8yOP+Kam6WibtAVsyvPXRQa2a0FEwxtjVqkFDuDbnr7XLpID3aA2xcn913C93ps94 X-Forefront-PRVS: 0157DEB61B X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(39840400002)(39450400003)(39410400002)(199003)(189002)(377454003)(24454002)(4001350100001)(2201001)(38730400001)(50986999)(77096006)(64126003)(54356999)(230700001)(90366009)(5009440100003)(65816999)(87266999)(189998001)(106356001)(6486002)(23746002)(5001770100001)(36756003)(97736004)(76176999)(229853002)(305945005)(81156014)(101416001)(6116002)(83506001)(3846002)(81166006)(65956001)(65806001)(8676002)(33656002)(7736002)(47776003)(68736007)(42186005)(66066001)(31430400001)(42882006)(92566002)(80316001)(59896002)(99136001)(50466002)(25786008)(105586002)(5660300001)(2906002)(6666003)(4326007)(2950100002)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR0701MB1709;H:[10.167.103.57];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY1PR0701MB1709;23:ibj/ogzmM7mh8+qQvaFIuTBF6aOmNFmZ4eB?= =?Windows-1252?Q?dtCtggsiLIsMADfrKICWobbOcMoVFHAvOq2gGYcsAPmAsrsfpVFxz7Sy?= =?Windows-1252?Q?tmcSC8n86uDVgbDvi6P7VtRTZp97NtY9aEES/u37vwf9Ch/IgG5zAQBU?= =?Windows-1252?Q?R2uUrDb3pppNtsXpkhwDYCThkGHeUUS+e7tx9Uccufhq7HhSTnm2vZH8?= =?Windows-1252?Q?acVKJnAqdtVYXxoe4PHuYYdFsFe99YkOQEHCZrU8QVSSdLisyYGy/nl+?= =?Windows-1252?Q?6g2Cv3tj6eu3uZHSst69CDusOTY+Jln2n2/NHiViMuDDazID/4PRWb+5?= =?Windows-1252?Q?FKq9i4Am76zkl2HY9Cr389yCYPMBXkZGpDF7+UksLUFKtS/+72gxOVoj?= =?Windows-1252?Q?pU/QMzAoPRWHq2RdP+o5Sh1+tj55yfMnMntmcF2z7SO0tz/v+AOUO9CF?= =?Windows-1252?Q?egUbTn0gX24vXmyPbtbUAa1cwL+rst8rBPPni4CvkPKSJ/rNtArkNUTe?= =?Windows-1252?Q?Y6T4M99TVF8M+azrMShVmO1i6eNxrmPdxISfqzMQbbmoNdt2qQg4iKys?= =?Windows-1252?Q?8xmgp2Htndp2eDPKVOe0VhNm2tC85NaWJxs9l1wL/HQUnjZIi+eEG/Iq?= =?Windows-1252?Q?J41khAleaD+W5hWAFZslU4CDbHiODhDGNWvIRyCJtMJYDWSCxE+vXFm5?= =?Windows-1252?Q?pIbiYeUKj+Xril1f+4ivYevMHzrY3C3tgms3HkC+QjbDGVlUpGJSB6oO?= =?Windows-1252?Q?+FgI0koxYQsG4Rg6Dg0QGxuZ+3+stFPoixIUn7sEC4wEmrr69QA2TMhj?= =?Windows-1252?Q?BUhRmNXHFiZ6SQxd0Zu/7wySUBn4sDR2H0XUK8lyeVXJbyAgfxL+4GH8?= =?Windows-1252?Q?mChSSds4Yky1qRVrSQwr+6Ot+8e6yTWQ3nDrjvIHmXr3j9ArlhTF9paM?= =?Windows-1252?Q?WErOwL4VbeDJ1SiWelogHmK3N2UpevQxJywvLFdZMOm00d4qECLphJQD?= =?Windows-1252?Q?EJZwu9Vilz+5MzwYnIvSqsf7Z1Gogorz2oUUsHQ39G6KIP63GvG+OxNQ?= =?Windows-1252?Q?53NDY6YmCG0Pg48qgyoW4l+6W5lt54tTY72ZAdF80Ml5d1Z1L0ceyJLr?= =?Windows-1252?Q?xtNOuUI0gUI9pH/0xGsZuFM9uJS6Ui8QuRv/K6wIbIcwo/9+W3r7a3KO?= =?Windows-1252?Q?2NpTdvnazpqC27devlQ/iFlX0Qs2EekxTza/ymY11THFnokWuWGZhaYo?= =?Windows-1252?Q?ekYGav3ykm/7eh7biAgLlxyfjOz0p14alVyz58bHly6mRrTUpzMgaCRW?= =?Windows-1252?Q?/34enCO/wW5w27OJYkFKjPvT4Hy0ttz5WL4GSC8KoYTHvc5ckWqvI+UM?= =?Windows-1252?Q?jr0l0Vnne9uiagtppx3kvuYT8eEk63lWUFAtlTSxQjFuYQlJx6hUxNI2?= =?Windows-1252?Q?gfxbmiyPrbgPITve17rZ4jCWmPFkxXRmvAnVfb/g7uCpD/G9DgjVG39k?= =?Windows-1252?Q?Xxu3kIeW6vXCh5+0pUP7SVotKREsCtJoucEfzbWWa9NZvAEUPk+6s6Gf?= =?Windows-1252?Q?4Ak8B9p+PYPKTfHOXbPvQ5MJimozYOIBN2rhVEXCHOSmO3SHmIEgjE/C?= =?Windows-1252?Q?A2vkVrKdoK1vadPRKRQQTSvv4a4ErcG05gv25L2QQIQjG?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1709;6:61pnXVIveXNw+FNZhtcIbKKdI+kN/cgBX+GZuER49q/UpEqiBWhQSR9kdIx9UHmj7Ph462R83YZGc+eAtoBbYlCEN8hnNGM9IU+u/+zT0UQdwN3Y1ZMTFyd1F2E/fDoczUIajJUkUTQL9otfzY6TqdpCbkSblGm/CXnhxzi+4sOBleK6WwJh/uI6Ky7sqEtApBmdzaIH1WEcnFxITQBRuJCWweOkAyk/6fBdcgYjCDHJF7RIJ9RgA3WrYBbSRaIDVfWGxfYRwfXVea1mDsAQdP5IiITohN0b97mcvsT9FPl0x9Bv4xAmAprn/y6ukWuA4qmJxrWzuGj7Ti3/2BknaL5UOparPLeg8B5xk9JA9RaQJxfw7F+quF/XMnInr9xI6NPD/P/sFRDMFpm0EkXxGTfQ2JuOQBGfvwGQ/jo1QdQ=;5:UbIkN7rHhBCG1Du8Dg/kO+RqZcugGbiZkQdhojOdBiHvcx3p7v+X6o9IWV83MNRgF+XjF4xxiURpO7cjTvfBInrG7sxoTa+3feo5T5Vzuix1p4OzgbGng7xwDNWN2C6DIjeWIK3B1Zz1UrNOIzpsGA==;24:suWN1yO9s/h2dgTzr/hBCDa8hP4A3UBR61IGygLw8WDr+uN2LDMppJ9bKu6NUfK/S8rigHEeFR6P4FFA7YhUgKTt3/TK92yqoDUrYMN9/kY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1709;7:tEHpJb/WMvys5G+F61THURv6avuv7UwXLgeKgsovtpFMxepZX0tgjNuI4E9w3P6TdV1Cln/VUIxLM7ENXhmaisSafcQtp5jcf8lMgQqu8tlQ3Nrr2J0mW7XOuIXvp4wxUqt+PiwaEFo7k3MrMP9IHTFfrPZRzwWv8RNX/RmoxZisqG3iY2bHJqLzSlDmdFcETxEYUJn/Y4oTGiFCVmW/brvIQ/mQXNjrS0v6M89JPV2T1+0kBjyiS1FRxAHgf+DXyHTLOAXSJmLpK+bXWfizf2LdvqwGzZxAUP4r5k0WQG6baFfkIAAQdNsVdAgZLPGrrmAEcsIa2O3I+Tbl0/PPv+PQ96LVifr5oOeg+0pl6eUfQPFKfK+4Y6G3wuW/6J5FwKIzWLMuqfJq0SesPVWztk2/vmDQJNmqIn23MKL9Ao9bRDoUUwYH42cWM9vdt6xXIqFEtnrePettzbTddaokCg== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2016 12:42:54.2903 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1709 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3101 Lines: 66 Hi, I got few review comments for this series from David Daney. I am reworking on this series and will sent v3 once it is done. So,kindly ignore this series Regards, -George On 12/13/2016 07:33 PM, George Cherian wrote: > > This series adds the support for Cavium Cryptographic Accelerarion Unit (CPT) > CPT is available in Cavium's Octeon-Tx SoC series. > > The series was tested with ecryptfs and dm-crypt for in kernel cryptographic > offload operations. > > Changes v1 -> v2 > -- Addressed a crash issue when more gather components are passed. > -- Redo the cptvf request manager. > - Get rid of the un necessary buffer copies. > -- s/uint*_t/u* > -- Remove unwanted Macro definitions > -- Remove the redundant ROUNDUP* macros and use kernel function > -- Select proper config option in Kconfig file. > -- Removed some of the unwanted header file inclusions > -- Miscellaneous Cleanup > > George Cherian (3): > drivers: crypto: Add Support for Octeon-tx CPT Engine > drivers: crypto: Add the Virtual Function driver for CPT > drivers: crypto: Enable CPT options crypto for build > > drivers/crypto/Kconfig | 1 + > drivers/crypto/Makefile | 1 + > drivers/crypto/cavium/cpt/Kconfig | 16 + > drivers/crypto/cavium/cpt/Makefile | 3 + > drivers/crypto/cavium/cpt/cpt_common.h | 166 +++++ > drivers/crypto/cavium/cpt/cpt_hw_types.h | 736 ++++++++++++++++++++ > drivers/crypto/cavium/cpt/cptpf.h | 69 ++ > drivers/crypto/cavium/cpt/cptpf_main.c | 733 ++++++++++++++++++++ > drivers/crypto/cavium/cpt/cptpf_mbox.c | 163 +++++ > drivers/crypto/cavium/cpt/cptvf.h | 145 ++++ > drivers/crypto/cavium/cpt/cptvf_algs.c | 424 ++++++++++++ > drivers/crypto/cavium/cpt/cptvf_algs.h | 110 +++ > drivers/crypto/cavium/cpt/cptvf_main.c | 971 +++++++++++++++++++++++++++ > drivers/crypto/cavium/cpt/cptvf_mbox.c | 205 ++++++ > drivers/crypto/cavium/cpt/cptvf_reqmanager.c | 581 ++++++++++++++++ > drivers/crypto/cavium/cpt/request_manager.h | 147 ++++ > 16 files changed, 4471 insertions(+) > create mode 100644 drivers/crypto/cavium/cpt/Kconfig > create mode 100644 drivers/crypto/cavium/cpt/Makefile > create mode 100644 drivers/crypto/cavium/cpt/cpt_common.h > create mode 100644 drivers/crypto/cavium/cpt/cpt_hw_types.h > create mode 100644 drivers/crypto/cavium/cpt/cptpf.h > create mode 100644 drivers/crypto/cavium/cpt/cptpf_main.c > create mode 100644 drivers/crypto/cavium/cpt/cptpf_mbox.c > create mode 100644 drivers/crypto/cavium/cpt/cptvf.h > create mode 100644 drivers/crypto/cavium/cpt/cptvf_algs.c > create mode 100644 drivers/crypto/cavium/cpt/cptvf_algs.h > create mode 100644 drivers/crypto/cavium/cpt/cptvf_main.c > create mode 100644 drivers/crypto/cavium/cpt/cptvf_mbox.c > create mode 100644 drivers/crypto/cavium/cpt/cptvf_reqmanager.c > create mode 100644 drivers/crypto/cavium/cpt/request_manager.h >