Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757976AbcLONyo (ORCPT ); Thu, 15 Dec 2016 08:54:44 -0500 Received: from mail.kernel.org ([198.145.29.136]:58680 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756275AbcLONym (ORCPT ); Thu, 15 Dec 2016 08:54:42 -0500 MIME-Version: 1.0 In-Reply-To: <833f99b1-d10b-27ba-e0f9-a7c6398fb63d@redhat.com> References: <1479901021-25064-1-git-send-email-jason.hui.liu@nxp.com> <833f99b1-d10b-27ba-e0f9-a7c6398fb63d@redhat.com> From: Rob Herring Date: Thu, 15 Dec 2016 07:54:17 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/1] of: of_reserved_mem: Ensure cma reserved region not cross the low/high memory To: Laura Abbott Cc: Jason Liu , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Frank Rowand Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 936 Lines: 22 On Wed, Dec 14, 2016 at 4:21 PM, Laura Abbott wrote: > On 12/14/2016 12:45 PM, Rob Herring wrote: >> On Wed, Nov 23, 2016 at 5:37 AM, Jason Liu wrote: >>> Need ensure the cma reserved region not cross the low/high memory boundary >>> when using the dynamic allocation methond through device-tree, otherwise, >>> kernel will fail to boot up when cma reserved region cross how/high mem. >> >> The kernel command line code setting CMA already deals with this. Why >> don't we just call the CMA code (cma_declare_contiguous) to deal with >> this? >> >> Rob >> > > That was proposed in the first version[1] but I think this is a generic > problem not specific to CMA. Even non-CMA reservations trying to span > zones could cause problems so the devicetree allocation code should > restrict reservations to a single zone. Fair enough, but that's not what this patch does. It's only for CMA. Rob