Date: Thu, 15 Dec 2016 15:46:28 +0100
From: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= <kernel@kempniu.pl>
To: Pali =?utf-8?B?Um9ow6Fy?= <pali.rohar@gmail.com>
Cc: Richard Purdie <rpurdie@rpsys.net>,
        Jacek Anaszewski <j.anaszewski@samsung.com>,
        Matthew Garrett <mjg59@srcf.ucam.org>,
        Darren Hart <dvhart@infradead.org>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, Bob Rodgers <Robert_Rodgers@dell.com>,
        Louis Davis <Louis_Davis@dell.com>, Jim Dailey <Jim_Dailey@dell.com>,
        Alex Hung <alex.hung@canonical.com>, Hui Wang <hui.wang@canonical.com>,
        linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] ALSA: hda - use dell_micmute_led_set() instead of
 dell_app_wmi_led_set()
Message-ID: <20161215144628.GB22695@kmp-mobile.hq.kempniu.pl>
References: <20161208123618.28603-1-kernel@kempniu.pl>
 <20161208123618.28603-4-kernel@kempniu.pl>
 <201612111140.38170@pali>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <201612111140.38170@pali>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 787
Lines: 21

> On Thursday 08 December 2016 13:36:14 Michał Kępień wrote:
> > --- a/sound/pci/hda/dell_wmi_helper.c
> > +++ b/sound/pci/hda/dell_wmi_helper.c
> > @@ -6,7 +6,7 @@
> >  #include <linux/dell-led.h>
> > 
> >  static int dell_led_value;
> > -static int (*dell_led_set_func)(int, int);
> > +static int (*dell_led_set_func)(int);
> 
> Suggestion: what about changing name to dell_micmute_led_set_func to 
> match real function name which is used after this patch?

While I like the idea itself, implementing it will double the number of
lines that this patch changes (6 vs. 12), arguably making its intention
less clear.  Please let me know if you would really like this to happen
(perhaps as a separate patch?), otherwise I will skip this idea in v2.

-- 
Best regards,
Michał Kępień