Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758627AbcLOPoe (ORCPT <rfc822;w@1wt.eu>);
        Thu, 15 Dec 2016 10:44:34 -0500
Received: from mail-wj0-f193.google.com ([209.85.210.193]:35664 "EHLO
        mail-wj0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755567AbcLOPoR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 15 Dec 2016 10:44:17 -0500
From: Pali =?ISO-8859-1?Q?Roh=E1r?= <pali.rohar@gmail.com>
Reply-To: Pali =?ISO-8859-1?Q?Roh=E1r?= <pali.rohar@gmail.com>
To: =?UTF-8?Q?Micha=C5=82_K=C4=99pie=C5=84?= <kernel@kempniu.pl>
Cc: Richard Purdie <rpurdie@rpsys.net>,
        Jacek Anaszewski <j.anaszewski@samsung.com>,
        Matthew Garrett <mjg59@srcf.ucam.org>,
        Darren Hart <dvhart@infradead.org>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, Bob Rodgers <Robert_Rodgers@dell.com>,
        Louis Davis <Louis_Davis@dell.com>, Jim Dailey <Jim_Dailey@dell.com>,
        Alex Hung <alex.hung@canonical.com>, Hui Wang <hui.wang@canonical.com>,
        linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] ALSA: hda - use dell_micmute_led_set() instead of
        dell_app_wmi_led_set()
X-Mailer: Modest 3.90.7
References: <20161208123618.28603-1-kernel@kempniu.pl>
         <20161208123618.28603-4-kernel@kempniu.pl> <201612111140.38170@pali>
          <20161215144628.GB22695@kmp-mobile.hq.kempniu.pl>
In-Reply-To: <20161215144628.GB22695@kmp-mobile.hq.kempniu.pl>
Content-Type: text/plain; charset=utf-8
Content-ID: <1481816580.2090.4.camel@Pali-Nokia-N900>
Date: Thu, 15 Dec 2016 16:43:00 +0100
Message-Id: <1481816580.2090.5.camel@Pali-Nokia-N900>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1182
Lines: 31

On Thu Dec 15 15:46:28 2016 Michał Kępień <kernel@kempniu.pl> wrote:
> > On Thursday 08 December 2016 13:36:14 Michał Kępień wrote:
> > > --- a/sound/pci/hda/dell_wmi_helper.c
> > > +++ b/sound/pci/hda/dell_wmi_helper.c
> > > @@ -6,7 +6,7 @@
> > > #include <linux/dell-led.h>
> > > 
> > > static int dell_led_value;
> > > -static int (*dell_led_set_func)(int, int);
> > > +static int (*dell_led_set_func)(int);
> > 
> > Suggestion: what about changing name to dell_micmute_led_set_func to 
> > match real function name which is used after this patch?
> 
> While I like the idea itself, implementing it will double the number of
> lines that this patch changes (6 vs. 12), arguably making its intention

If some patch makes final result of code better then metric number of lines is not priority.

> less clear.   Please let me know if you would really like this to happen
> (perhaps as a separate patch?), otherwise I will skip this idea in v2.
> 
> -- 
> Best regards,
> Michał Kępień

If it will be in this or another following patch... I dot care. But this is sound subsystem, so sound maintainers need to decide what they prefer.

-- 
Pali Rohár
pali.rohar@gmail.com