Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758634AbcLOPtW (ORCPT <rfc822;w@1wt.eu>);
        Thu, 15 Dec 2016 10:49:22 -0500
Received: from www62.your-server.de ([213.133.104.62]:59421 "EHLO
        www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755791AbcLOPtV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 15 Dec 2016 10:49:21 -0500
Message-ID: <5852BB73.3080600@iogearbox.net>
Date: Thu, 15 Dec 2016 16:49:07 +0100
From: Daniel Borkmann <daniel@iogearbox.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexei Starovoitov <ast@fb.com>
CC: Wang Nan <wangnan0@huawei.com>, Joe Stringer <joe@ovn.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sample/bpf: Make perf_event_read() static
References: <20161215152927.GC6866@kernel.org>
In-Reply-To: <20161215152927.GC6866@kernel.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-Authenticated-Sender: daniel@iogearbox.net
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1622
Lines: 45

On 12/15/2016 04:29 PM, Arnaldo Carvalho de Melo wrote:
>
> While testing Joe's conversion of samples/bpf/ to use tools/lib/bpf/ I
> noticed some warnings, do you guys mind if I put patches like the one
> below in my tree, pushing to Ingo soon?
>
> Or is there anything subtle against doing so?

Fwiw, no objections from my side, there is currently nothing in
net/net-next tree that could cause conflicts regarding the below
change, so should be good to take this route instead.

> ----
>
> While building samples/bpf/ on a Fedora Rawhide container, with
> clang/llvm 3.9 I noticed this:
>
> root@1e797fdfbf4f linux]# make -j4 O=/tmp/build/linux/ samples/bpf/
> make[1]: Entering directory '/tmp/build/linux'
>    CHK     include/config/kernel.release
>    GEN     ./Makefile
>    CHK     include/generated/uapi/linux/version.h
>    Using /git/linux as source for kernel
> <SNIP>
>    HOSTCC  samples/bpf/trace_output_user.o
> /git/linux/samples/bpf/trace_output_user.c:64:6: warning: no previous
> prototype for 'perf_event_read' [-Wmissing-prototypes]
>   void perf_event_read(print_fn fn)
>        ^~~~~~~~~~~~~~~
>    HOSTLD  samples/bpf/trace_output
> make[1]: Leaving directory '/tmp/build/linux'
>
> Shutup the compiler by setting that function as static.
>
> Cc: Alexei Starovoitov <ast@fb.com>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Wang Nan <wangnan0@huawei.com>,
> Cc: Joe Stringer <joe@ovn.org>
> Link: http://lkml.kernel.org/n/tip-2wkr4ymwhdie0stbkbiyplt5@git.kernel.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Acked-by: Daniel Borkmann <daniel@iogearbox.net>

Thanks,
Daniel