Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758671AbcLOPyl (ORCPT <rfc822;w@1wt.eu>);
        Thu, 15 Dec 2016 10:54:41 -0500
Received: from mail.kernel.org ([198.145.29.136]:47468 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1756105AbcLOPyk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 15 Dec 2016 10:54:40 -0500
Date: Thu, 15 Dec 2016 12:54:34 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Alexei Starovoitov <ast@fb.com>, Wang Nan <wangnan0@huawei.com>,
        Joe Stringer <joe@ovn.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sample/bpf: Make perf_event_read() static
Message-ID: <20161215155434.GF6866@kernel.org>
References: <20161215152927.GC6866@kernel.org>
 <5852BB73.3080600@iogearbox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5852BB73.3080600@iogearbox.net>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2201
Lines: 59

Em Thu, Dec 15, 2016 at 04:49:07PM +0100, Daniel Borkmann escreveu:
> On 12/15/2016 04:29 PM, Arnaldo Carvalho de Melo wrote:
> > 
> > While testing Joe's conversion of samples/bpf/ to use tools/lib/bpf/ I
> > noticed some warnings, do you guys mind if I put patches like the one
> > below in my tree, pushing to Ingo soon?
> > 
> > Or is there anything subtle against doing so?
> 
> Fwiw, no objections from my side, there is currently nothing in
> net/net-next tree that could cause conflicts regarding the below
> change, so should be good to take this route instead.

Thanks a lot! 

Ah, since it seems the overhead of having clang/llvm/bc/findutils in
addition to what I have in the containers for distros with suitable
packages is small, I'll probably end up building samples/bpf/ in those
containers, in addition to building perf with/without libelf and
objtool.

This way I'll catch build problems everytime I prepare my pull reqs to
Ingo and hopefully fix them then.

- Arnaldo
 
> > ----
> > 
> > While building samples/bpf/ on a Fedora Rawhide container, with
> > clang/llvm 3.9 I noticed this:
> > 
> > root@1e797fdfbf4f linux]# make -j4 O=/tmp/build/linux/ samples/bpf/
> > make[1]: Entering directory '/tmp/build/linux'
> >    CHK     include/config/kernel.release
> >    GEN     ./Makefile
> >    CHK     include/generated/uapi/linux/version.h
> >    Using /git/linux as source for kernel
> > <SNIP>
> >    HOSTCC  samples/bpf/trace_output_user.o
> > /git/linux/samples/bpf/trace_output_user.c:64:6: warning: no previous
> > prototype for 'perf_event_read' [-Wmissing-prototypes]
> >   void perf_event_read(print_fn fn)
> >        ^~~~~~~~~~~~~~~
> >    HOSTLD  samples/bpf/trace_output
> > make[1]: Leaving directory '/tmp/build/linux'
> > 
> > Shutup the compiler by setting that function as static.
> > 
> > Cc: Alexei Starovoitov <ast@fb.com>
> > Cc: Daniel Borkmann <daniel@iogearbox.net>
> > Cc: Wang Nan <wangnan0@huawei.com>,
> > Cc: Joe Stringer <joe@ovn.org>
> > Link: http://lkml.kernel.org/n/tip-2wkr4ymwhdie0stbkbiyplt5@git.kernel.org
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
> 
> Thanks,
> Daniel