Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756200AbcLOQDJ (ORCPT ); Thu, 15 Dec 2016 11:03:09 -0500 Received: from mail-dm3nam03on0065.outbound.protection.outlook.com ([104.47.41.65]:57691 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752007AbcLOQDH (ORCPT ); Thu, 15 Dec 2016 11:03:07 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Robert.Richter@cavium.com; Date: Thu, 15 Dec 2016 16:48:45 +0100 From: Robert Richter To: Yisheng Xie CC: Russell King , Catalin Marinas , Will Deacon , Ard Biesheuvel , David Daney , Mark Rutland , Hanjun Guo , James Morse , , , , Hanjun Guo , Xishi Qiu Subject: Re: [PATCH] arm64: mm: Fix NOMAP page initialization Message-ID: <20161215154845.GB8111@rric.localdomain> References: <1481307042-29773-1-git-send-email-rrichter@cavium.com> <83d6e6d0-cfb3-ec8b-241b-ec6a50dc2aa9@huawei.com> <9168b603-04aa-4302-3197-00f17fb336bd@huawei.com> <20161214094542.GE5588@rric.localdomain> <4bc9df75-1b67-2428-184e-ce52b5f95528@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4bc9df75-1b67-2428-184e-ce52b5f95528@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [92.224.61.108] X-ClientProxiedBy: AM4PR01CA0009.eurprd01.prod.exchangelabs.com (10.164.74.147) To CY1PR07MB2346.namprd07.prod.outlook.com (10.166.194.145) X-MS-Office365-Filtering-Correlation-Id: 3b11f94c-e647-4a2f-f3a9-08d42501e12e X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CY1PR07MB2346; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2346;3:imT1LwrOib7gMJSDdaMghzdqysyf7qLQM8JjtpuO4ZG1s3KG1a79iAp24a25jdLlslPekOHnKQ4wpPshIeTTPmddmGFW6v6Eq4HyhBOiUhB9QrHriEyLExdHmY9YzGAvDcX/8kHgX6ckJZQWULxpNhJsKKDdQ3NEviKuUYXEKCGkecGHAmgU9biaCHbZ4OlRD7+9BZUlF070mP/zVVU/lzp0HlOe3q3vinb2KICOgmS4hCKHcWTdK4UVY6JRxYfcNieJKOuBLWytOsqJ39Wa9Q==;25:zM8J2QpY5j6Y538n50G50jRCAUfYhhlh9FufDMEEp/KLR/JkJxpMw8dmFVTm8HHI3Hf1l7EywORQ5HDfmf8CPA1PbhUa34prYkIRm5jJID+8WDgK289dKFB3y/l/AnpteNZcSpQ8EzEWAnNhuCdUcDhKNnco2TAYO52xibFTQcdAcF4O1ARMfFnbGRLM8tZ8q2V2vER6yG2ivdMDyrc2MPNl7cO45BXIi9Ms9xt+6rtjpn1W8qpDf5tuX/+XR02Aqks0sDpiIiRlt/IEYEjg7N9K6C3LQC/kJvc879RQfvv4Tu2x/fO4smgPt71xWuxhB/7ibBNF4LpUtQgOVnxe2EtI8GDbRzZZbHTXli8CMsqSN6UEoSCZb3DgRsKXAnlU5Zd2z0cIeoxBkXZhYKXP7i352mU6PLPxZ/ZWdAvJyzY1i2a1BTGWDqAtOWvN7okgvG/JXrH53I7df3RwU1PsHw== X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2346;31:E/5sLGwpXQOZXsVmp93AfCBdy6KRf25HQXCFZDXc3N/H9z+y4wkNqNtToD5QQ3LuPbyBNp+TylOJVsl3eI3pQOjTYPNQuhJYjfzFNCnYeIsj2qBIPYVaLr5PU8X2Yzx1nnPG6rmpXXBSRyEgQ/ikCT7ZEgIQVu2DoWrX4bCiQYId3V6PE4HWYr/ysC7dqP/aQxDEYz4sJcN2sT6Npt2YoJUcoON+4WV10zN2uSq8g5a1tXbQKnQG3SQq6SNwQla4uNpEtuJVcuWpR8XXr7/v6g==;20:r1nUx4jV1ROSdL35bbefDKnfDhAcTQRSCLYu58pHJIHwcTwUpVCY/nlc4kL5A+ayheO74YhKyIX56wTQesLgQzsBX0NqY2YqV1DsPV0ggb08XylI18cGY1UZYSFNiQFdm7ZSPW4zf1NymSimAMAQ3jG28Myi8/Fxv4bQqIIxF5DTAqpdbqFbMoaEhqXRoCruV2f2AmX7GtqNiNI8ZK5obUwkdylVNTiFu6R+YmlTA1HgiWW6ZiugWtMfZsVauNxYsLxEkUwW2Ri9E3p8CJwewcrDZk+ECTAmnVTZaNg8un0k+WvHrjmDjnZ2jzaHakBpEPR7ViMSb7JHrTMi0BGBBFBZVa3e3eBfBhy5IleNIgC8y6V03GGxDFJZTwtBE8Q7SDG72ntv9zsSoYgqoTrR1bX1tYfWqk2+fhFi9UCJl6c16OrwgH3tj732mO7qyHSSkEpT8VAFX8Js7AaG21yL6zf23huY+mD2SI2TGf1V3RdTXKMIRkP4HyegOTV/P6yG X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123564025)(20161123562025)(20161123555025)(20161123558021)(20161123560025)(6072148);SRVR:CY1PR07MB2346;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2346; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2346;4:VRcaEx/6amH3jmBVmmQjgHQ5+Km2n9eecqURxKhWL2sivNJmIh3+5Kk7v5S7/jI2VLYLeYNW3SavYSratT8a+YDbpk/FVfCtudzTewlz3oqidKL4wyfq4MSU1u7kU2VdSnoJB1CGJc1go2p603K0Rkd6XP2ZrnZzJyfJec8qzTX8QeYP0pke87hS3Dd8znBwdz/9wvxPYN9CEkSSDDX9LY/JkvdNFdDC5UBeOUB7UrNNuBUbqa+Xteo+gFVfqoIZ5WBgBMFPi6aDtOgW9R/CkC0rwSApCgL/6DZfzCpFBV5WkARmeenGYDSV23ZlahZpiMLC3UuZjhioFz5Vusx1/xjmp/ksRpCEimG9GYaXDIEyQl4Cn7xwi+nZPVALLGOVyStQBMM0Rmgg2ORfP7RDUvovh50wOaU7m0uuhjUk62Z4AlJXp3cFjtkyWZGiepsX1d4zhxIRIVbU9ewCqzRsW356yXn7Znn/rWTehYweC/L+m/MqRjURXiqTTURWqLAEI8eMLt5g3iJHZZPYUe0oSPyvtDXtvDqxbrv4dpyQbbOzmnxmdLnUNIdGSKADxdKqtSoRRaVJFhlr4OChiG52qPK6hdzyvU5F9szWD0IcVMI= X-Forefront-PRVS: 0157DEB61B X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39840400002)(39450400003)(39410400002)(189002)(199003)(24454002)(81166006)(81156014)(8676002)(9686002)(4001350100001)(106356001)(42186005)(110136003)(229853002)(3846002)(6116002)(97736004)(2870700001)(6916009)(68736007)(50466002)(86362001)(83506001)(50986999)(66066001)(4326007)(33656002)(7416002)(2906002)(93886004)(47776003)(54356999)(101416001)(25786008)(38730400001)(5660300001)(23676002)(92566002)(189998001)(2950100002)(6666003)(7736002)(305945005)(1076002)(6506006)(76176999)(105586002)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR07MB2346;H:rric.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjA3TUIyMzQ2OzIzOlFIRTJtYjVJTXN1ZlQzZDJBTGtjWjUydDdU?= =?utf-8?B?OUc2QVFaNGQ2V1U5OUNpRVBFN09QcmdVWW1naEROSVJGbHBVOEhRSDJ0N2Fu?= =?utf-8?B?aUZMbW5mK1R4WDI1M1pEWWVRdzdubjRZUVdhNGJpUjcyRzZ3bWJjMlU5TFRy?= =?utf-8?B?ZHZrOGlHcTB6R3pQZDBBVUJybWZLQUdiMU8rTmlERUN0VnhJQzJMN2phZWo4?= =?utf-8?B?SG5USDNpUHpUM2c2Y0tQdzB6d3AyNWVhSzJmaWFjbys4YWpOWEdITU9kR1hk?= =?utf-8?B?dnhyMEJnellYRlMxOFBBa3BoblkvYzBITVF4ZWVtZ2s0ZXB0MmFkNFl3UTZ6?= =?utf-8?B?WlFwNU44Rk1xbDBZYXlIeGZScjYwS2FRUElTUGphTTNKRWRhei9OeVJOTzdj?= =?utf-8?B?V2diN3hTU2N5djRGaXA2NitNRmc4VVFXV2h2RUFoK3dXN2xJSUcyYlVHbEND?= =?utf-8?B?eHgwcmpjSFcvQ3FMMUxQYnRWd0M2L01PbUJ1OFVablBiK20zNzV4SVNRa1pl?= =?utf-8?B?eUowS0x3ZmZZWGdsUDMvcUNkNjYxUDFoSDllOVdsV3pMaHZ3YmR1TVR6N05V?= =?utf-8?B?dWFWZEhscWF2NTJHa2NsOE5DWTBzQVhkM2I1V1QvVXcwbVVBRFBhZ2NvNzgw?= =?utf-8?B?S0dqN1BZaHhmZk52V3kza0hVNTVRdVNQU2NVTUR0YytGMzNLVHkwS3JmeEg1?= =?utf-8?B?QS9XQ3B3TjNvUTJ5MHkwcTVrOFlVNXVmdFJHbDRQUWJIUFpacHdvTFJPYy9h?= =?utf-8?B?Mi9KMDFDK1ZuS2x4a0Rab1RMUXhNNVBRUlc2WERrY3VUcnQzbHpoMzNmOEVS?= =?utf-8?B?Rmh6MzgrcGtONUZVZWxreGJtaVFFWEtJS1YrckJHcmZWdzlIaWJEUkthb0RH?= =?utf-8?B?UHVQRUgzTmFvZ3NET094Z2NIL1VCUkxYUUZNd2JuOURIWVNBYThDR0cwRWIv?= =?utf-8?B?UHRrT3l3andoSHZKY1dQMEpYd0NGTGdpTlZJd1JRUGk5VFdHams0T2RrUWVE?= =?utf-8?B?WWY3bFdTbnFTTytkc0dDVkNlSko2Q3NZek5IYlNxU0dLbDhaQXZLZkVRdmUz?= =?utf-8?B?V1MvZEtpRnhXeWZoM2wwRjVSOUZEYkcwcWFkSThic0ZLRUc1RE54djBVa3JW?= =?utf-8?B?TDRhT1gvSzRvWDhZMDlXamJmb2VYMnN1cC9VREdMRmVLN2dCUUtMSmx4ZEo5?= =?utf-8?B?czYyKzlYa2g0WWFGOEhvaGF5NmVIMk92VStBT3NrMG5KdkhoY25OQ0E5cUlV?= =?utf-8?B?KzlZaU9qbkNKRDhNbEV3Z2oxWlQrdEpFQ1V6QXJjRVRsaW0rYko4cEdhcnpX?= =?utf-8?B?ZUJFQ2tKTHJKQ1BVMmlzL1RxL3RacllJWVJxS3FSOGQ5NXNIR2pEenBVN3Fw?= =?utf-8?B?M0t1c2RFQ2hXTEVUVFoxWk1XWElrQXVZYmFLSGVBOWtmU3hpWUpOOUJndjEx?= =?utf-8?B?N1ZoRzFUd0gxNElsVlp2YkswL2s3WmhtVnVwVjA5MTkwSUlYaS90N3ZrcVRN?= =?utf-8?B?MWdUVHdPdDJyMlo5dmVTWjZ1SFRmNm1tblhubG1wZHkxcENDZlpTeDFxZ1pl?= =?utf-8?B?SXlJeG52NW5JY3c5Z0ZOeC9yLys2U3RLQW5NSkpQVnU5V2F2NStya3dzZXlM?= =?utf-8?B?MkMyclkzTnp6Y0cyQlR3b2pEY3d6aWNuMXQxR0FBZlFuYi9GSGZ4UVhRNWx4?= =?utf-8?Q?21PIq8poP9RE36Bkm5tRlIACGMw/oqfuUMtMCMu?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2346;6:bvYVEGXJabxeFfcJ/h1SolXdhK1cZ7+mIV4UcfBMrVOJW4fMiZ8bKXw+zAzbWWRlSgl10W+gq1Jay0gonyWg02Y0els7I9C4uX2+WkNmie1sft1CplsZU9kO7RbKiI2Y/WEg9ejLlY54AP6+zdsBdDcwnk405MWvQQyCsav6Z7j7f8TvCyhQyh121J1aYzpF7xWpjYKJq17lCCLJjBTC3UneDUER06QnqYxY3tNuG1phe+25bN8bn4xxFdVwQEEWeRVJhKQeqTN+ZEPyn//j/HGJumK3uBk38ljecyqn9Gs8DnSLux6hURWsDpj7O8hGNEJ9jInm3oz6KXtu0vT2+6WTHMrXC9UXHDPuGj9yNpz3XBu5TI2r1ujYrehAwWOzAr6kRY5Et5tZ5gVAj5GtEgv63d4tONXBmMW0lWHG0qA=;5:o35tG2T7kofCDwZIBlFnqWveI/K0wLJ38NcRDGsZ4vJTQnjNKhA+0l03DXXY1QGSOUWtCWKHMqbUxrS0RtJJEJU8vU4GKN2A7e40nexjqgm9EmccHLpnRjTwVGwsXnTz41tcPhJe8F11vp8opOAOLg==;24:QoBlvE3V542XKc29V/+6f/mMwIlIh0MUuNmUjEIcqZmsRwhTxAvcZUGyvaRW04XAt623jTVD4eHLDGAXkXKTX2TTjcQ7fuhSPr43+Ko5Niw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2346;7:8KXPbP7loh3+SSNJdUH3QND2tne4hIXHbqZBKdZ9vRoaiR1WG7biTYTLPzRtoJP69ZUY78m6JpSjqQEsjkyJwtD8zWilMv34MpLEJ105TqmdB4FDFUXS3RN/c3ek6VXvIkHh/eLj7zbvmcPKgIEg9Cj5R/eska2mEdCDHDdqmNTOuUqWqO+pTVHb6+XI7tXRGzLjgOyq6P3O7pjLDWM1wwkbO3sjXKENKt5aNrpbOazJmqoGVovPxxigHETQytt487+LvtWsl3huMKx41Ehc9kDlyEOaL3WxqPnKsRSKdKhCldAYX+6UIP7XfcIfCUMJSbXhkLKJRK9ddhoTOg6YJmyVopGn6tERlxC1HYcFuKdTAIDjjBPfikkiJXzzP9vdxGQT39lC0E1lXHVKRipMIIxcpcD63lZu0QQCrMfqpikmJPwYYNboRJ2wUfQ5UdzQbEEHwtYU64FTpZzJdxfQ0g== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2016 15:48:54.2606 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2346 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 511 Lines: 15 On 15.12.16 11:01:04, Yisheng Xie wrote: > > I sent a V2 patch that uses pfn_present(). This only initilizes > > sections with memory. > hmm, maybe I do not quite catch what your mean, but I do not think > pfn_present is right for this case. > > IMO, The valid_section() means the section with mem_map, not section with memory. Right, the section may be uninitialized with the present flag only. valid_section() is better, this is also the pfn_valid() default implementation. Will rework. Thanks. -Robert