Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758194AbcLOQXo (ORCPT ); Thu, 15 Dec 2016 11:23:44 -0500 Received: from mx2.suse.de ([195.135.220.15]:39145 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755135AbcLOQXl (ORCPT ); Thu, 15 Dec 2016 11:23:41 -0500 Date: Thu, 15 Dec 2016 17:23:37 +0100 From: Petr Mladek To: Geert Uytterhoeven Cc: Linus Torvalds , Sergey Senozhatsky , Joe Perches , Steven Rostedt , Mark Rutland , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] printk: Remove no longer used second struct cont Message-ID: <20161215162336.GA18152@pathway.suse.cz> References: <1481806438-30185-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1481806438-30185-1-git-send-email-geert@linux-m68k.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 670 Lines: 21 On Thu 2016-12-15 13:53:58, Geert Uytterhoeven wrote: > If CONFIG_PRINTK=n: > > kernel/printk/printk.c:1893: warning: ‘cont’ defined but not used > > Note that there are actually two different struct cont definitions and > objects: the first one is used if CONFIG_PRINTK=y, the second one became > unused by removing console_cont_flush(). > > Fixes: 5c2992ee7fd8a29d ("printk: remove console flushing special cases for partial buffered lines") Great catch. It seems that nobody tried the build without CONFIG_PRINTK at that time. > Signed-off-by: Geert Uytterhoeven Signed-off-by: Petr Mladek Best Regards, Petr