Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758449AbcLOQ1S convert rfc822-to-8bit (ORCPT ); Thu, 15 Dec 2016 11:27:18 -0500 Received: from mail-cys01nam02on0095.outbound.protection.outlook.com ([104.47.37.95]:45034 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758342AbcLOQ1Q (ORCPT ); Thu, 15 Dec 2016 11:27:16 -0500 X-Greylist: delayed 85844 seconds by postgrey-1.27 at vger.kernel.org; Thu, 15 Dec 2016 11:27:16 EST From: Hartley Sweeten To: Ian Abbott , Piotr Gregor CC: "gregkh@linuxfoundation.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] drivers: staging: comedi: fix function prototypes Thread-Topic: [PATCH] drivers: staging: comedi: fix function prototypes Thread-Index: AQHSVhAoH8z0ZhSp3EuFyGZbqZlG/qEHnOcAgAFIuoCAAEiA0A== Date: Thu, 15 Dec 2016 16:12:20 +0000 Message-ID: References: <20161214134208.GA26114@westernst> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=HartleyS@visionengravers.com; x-originating-ip: [184.183.19.121] x-ms-office365-filtering-correlation-id: 8b1d787b-9679-4faf-6ff0-08d4250525ea x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:SN1PR0101MB1567; x-microsoft-exchange-diagnostics: 1;SN1PR0101MB1567;7:FDj8tarHlNDicKacbOUgS/rMmMpjwjxTdsQe5z+BqH1WKl+3rySKXg7kZ0U5dpYcMmMIgrS7v6J9lTs6Yyh6sme2uAl1YXfadnRB1b2nccU4NJb/XPlD4Kz+BShO52ElMARCpjl0GEtAfLbUGOKTubDm/4zGRLfDxJXb/SjJyezakaTaVM9a9Lexp9wvZTMsx77SWIXyduvvU0LbXuZa+F01lPLSTaC4hBKC+gfaSj0rV9v3ufiPS59ThoRa/25qFiX6QidhVTtSUZ/AyK72Z5GWSD03j1D7uXCgPHx2A5dkAtOMo3FlznCp+o+vfdpj0uBEwSVFTKkOSIz8CwmbZLpM/EFOlmrjJEuXet4fSq6h8pRu20UPBE6P++FtRWxLFDCWMiMOGKTdEfoN6ZGJu5F9YjnMIR5GzaCkfVkbI5qcWcqBNJWHNxN1Ap4O2TzjPWXmwr7MXu/CATifuFmW0g== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123555025)(20161123564025)(20161123558021)(20161123560025)(20161123562025)(2016111802025)(6043046)(6072148);SRVR:SN1PR0101MB1567;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0101MB1567; x-forefront-prvs: 0157DEB61B x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(39450400003)(39410400002)(39830400002)(189002)(377454003)(24454002)(199003)(81156014)(97736004)(6116002)(3846002)(50986999)(3660700001)(189998001)(7736002)(66066001)(4326007)(86362001)(2950100002)(575784001)(3280700002)(101416001)(122556002)(76176999)(7696004)(229853002)(9686002)(2900100001)(102836003)(5660300001)(54356999)(8936002)(305945005)(74316002)(2906002)(77096006)(8676002)(6436002)(81166006)(105586002)(106116001)(80792005)(6506006)(33656002)(68736007)(25786008)(5001770100001)(106356001)(38730400001)(92566002);DIR:OUT;SFP:1102;SCL:1;SRVR:SN1PR0101MB1567;H:SN1PR0101MB1565.prod.exchangelabs.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visionengravers.com X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2016 16:12:20.1383 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d698601f-af92-4269-8099-fd6f11636477 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0101MB1567 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 929 Lines: 25 On Thursday, December 15, 2016 4:47 AM, Ian Abbott wrote: > On 14/12/16 16:14, Hartley Sweeten wrote: >> On December 14, 2016 6:42 AM, Piotr Gregor wrote: >>> -struct pci_dev *comedi_to_pci_dev(struct comedi_device *); >>> +struct pci_dev *comedi_to_pci_dev(struct comedi_device *dev); >> >> For the function prototypes I prefer no names for the "pointer" parameters. >> >> The "struct foo *" declaration is just as clear as "struct foo *bar". > > Maybe, but checkpatch.pl doesn't agree (not since commit > ca0d8929e75ab1f860f61208d46955f280a1b05e anyway)! Hmm.. Missed seeing that one go in. I still think it's silly to name struct pointers in function arguments. Especially since that normally leads to stuff like 'struct foo *foo' where the parameter name is the same as the struct name. Void pointers and generic types are a different matter. Naming those makes sense for clarity. Oh well... Just my 2 cents... Hartley