Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757524AbcLOQmh (ORCPT ); Thu, 15 Dec 2016 11:42:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44474 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755135AbcLOQme (ORCPT ); Thu, 15 Dec 2016 11:42:34 -0500 Date: Thu, 15 Dec 2016 18:42:31 +0200 From: "Michael S. Tsirkin" To: "Gonglei (Arei)" Cc: "Zeng, Xin" , Halil Pasic , "linux-kernel@vger.kernel.org" , "qemu-devel@nongnu.org" , "virtio-dev@lists.oasis-open.org" , "virtualization@lists.linux-foundation.org" , "linux-crypto@vger.kernel.org" , "Huangweidong (C)" , Claudio Fontana , Luonengjun , "Hanweidong (Randy)" , "Xuquan (Quan Xu)" , "Wanzongshun (Vincent)" , "stefanha@redhat.com" , "Zhoujian (jay, Euler)" , "cornelia.huck@de.ibm.com" , longpeng , "arei.gonglei@hotmail.com" , "davem@davemloft.net" , "Wubin (H)" , "herbert@gondor.apana.org.au" Subject: Re: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver Message-ID: <20161215184153-mutt-send-email-mst@kernel.org> References: <1481716249-185392-1-git-send-email-arei.gonglei@huawei.com> <1481716249-185392-2-git-send-email-arei.gonglei@huawei.com> <33183CC9F5247A488A2544077AF19020DA163033@DGGEMA505-MBX.china.huawei.com> <82063967A54EF84C8AFCD6BD7F6AD93310C14374@SHSMSX103.ccr.corp.intel.com> <33183CC9F5247A488A2544077AF19020DA16320F@DGGEMA505-MBX.china.huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33183CC9F5247A488A2544077AF19020DA16320F@DGGEMA505-MBX.china.huawei.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 15 Dec 2016 16:42:34 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2322 Lines: 64 On Thu, Dec 15, 2016 at 01:08:51AM +0000, Gonglei (Arei) wrote: > > > > > Regards, > -Gonglei > > > > -----Original Message----- > > From: Zeng, Xin [mailto:xin.zeng@intel.com] > > Sent: Thursday, December 15, 2016 8:59 AM > > To: Gonglei (Arei); Halil Pasic; linux-kernel@vger.kernel.org; > > qemu-devel@nongnu.org; virtio-dev@lists.oasis-open.org; > > virtualization@lists.linux-foundation.org; linux-crypto@vger.kernel.org > > Cc: Huangweidong (C); Claudio Fontana; mst@redhat.com; Luonengjun; > > Hanweidong (Randy); Xuquan (Quan Xu); Wanzongshun (Vincent); > > stefanha@redhat.com; Zhoujian (jay, Euler); cornelia.huck@de.ibm.com; > > longpeng; arei.gonglei@hotmail.com; davem@davemloft.net; Wubin (H); > > herbert@gondor.apana.org.au > > Subject: RE: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver > > > > On Thursday, December 15, 2016 8:45 AM, Gonglei (Arei) Wrote: > > < > > diff --git a/drivers/crypto/virtio/virtio_crypto_core.c > > < > b/drivers/crypto/virtio/virtio_crypto_core.c > > < > > new file mode 100644 > > < > > index 0000000..c0854a1 > > < > > --- /dev/null > > < > > +++ b/drivers/crypto/virtio/virtio_crypto_core.c > > < > > @@ -0,0 +1,474 @@ > > < > [..] > > < > > + > > < > > +static void virtcrypto_dataq_callback(struct virtqueue *vq) > > < > > +{ > > < > > + struct virtio_crypto *vcrypto = vq->vdev->priv; > > < > > + struct virtio_crypto_request *vc_req; > > < > > + unsigned long flags; > > < > > + unsigned int len; > > < > > + struct ablkcipher_request *ablk_req; > > < > > + int error; > > < > > + > > < > > + spin_lock_irqsave(&vcrypto->lock, flags); > > < > > > < > Would it make sense to use a per virtqueue lock > > < > like in virtio_blk for example instead of locking on the whole > > < > device? OK, it seems you use only one dataqueue, so it > > < > may not be that relevant. > > < > > > < Currently yes, both the backend device (cryptodev-backend-builtin) > > < and the frontend driver use one dataqueue. > > < > > > > I think it makes sense to use per virtqueue lock here though it only uses one > > queue so far, > > but in the spec we already have multi queues support. > > > Yes, I agree. Will do that in V8 soon. > Hope to catch up with Michael's pull request for 4.10. > > Regards, > -Gonglei I merged v7, this change will have to wait. Sorry.