Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932821AbcLOQvg (ORCPT ); Thu, 15 Dec 2016 11:51:36 -0500 Received: from mail-he1eur01on0102.outbound.protection.outlook.com ([104.47.0.102]:9198 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752560AbcLOQve (ORCPT ); Thu, 15 Dec 2016 11:51:34 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peda@axentia.se; Subject: Re: [PATCH v2] i2c: designware: Cleaning and comment style fixes. To: Luis Oliveira , wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com, jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: Cc: Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com, CARLOS.PALMINHA@synopsys.com From: Peter Rosin Organization: Axentia Technologies AB Message-ID: Date: Thu, 15 Dec 2016 16:17:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Originating-IP: [217.210.101.82] X-ClientProxiedBy: AM4PR0101CA0025.eurprd01.prod.exchangelabs.com (10.167.254.35) To DB6PR0201MB2311.eurprd02.prod.outlook.com (10.169.222.150) X-MS-Office365-Filtering-Correlation-Id: 5971bcd7-c009-4f57-6789-08d424fd715c X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DB6PR0201MB2311; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0201MB2311;3:1mKg9KzXydZ8sVpCVYOmcNd2k+orsRcyj2+WIVD31GSxKUENAatE8kr3ldpEubTk8cOKVwSEEfyvCApW0PU9C95EEhrVZNB1oma624oZGzLrtHnYrjhQzV9Giv3fd1aysT9c9uQ189zofrC6MLfeyJ8FxanAtxEz4BhG47K/PnN44We3GT86JPPGlwd93fchZZrJm8/iKyHEK2xvGSr2ZI/DJBIowO9FNQykcbkiHcHKwPwA2x578zu7BlgwEtX4ARr0GUZMIRJeORf9xBRmPA==;25:tZKbBAAhMm0++Zc7mtWkMaA7cRnkz46QyiGEdapeFsfS34JmSYWYqZXOJ3Yoh9QiOlGUu6QCnmT70ygiaia1NEn81At3JK36FOq8AyqAsKn8F9QgFwlU6BrX8xiTVzBSxi70xGlEQTh/dr8WXW1iJJZcVDszqe/caw4rOpbbnzEQr/L/pOjPlOoqR+5oqzitholjneBgYPPATufN5TDp8y4qDcbz0gbXyJMniTPlepsfh352fFJ93sEy8IL3K9ksGEKcXe2PmtOv3m2cjIbgdP4Hes8p/FGj5E27Tf3YISEGPfWBheGeBrr94bb/OMogWPRo7smCeVtAnE4UmZqA+AqxXNcKfSfrZC9ACjiCq0ZRzxVYGkaJqWEU81cQg+EOxSuQGYerNaPPbEV4Y9LvaGsA9qE6a58hAA29Duy6OmUUqdpl051VgTyfVfYwc5R260RGLOHDEkZe5QQ9cch2ZQ== X-Microsoft-Exchange-Diagnostics: 1;DB6PR0201MB2311;31:TyXQJbYezXzwLsOVb/52sNEfXynVhczL9WSKu2FE7G13O/dJ/8wQIKzMwtDpq/mJPuK1xe6wW0Plq6/X0rSjbUZ9RWSI5Y7Tw85L33oXouuxhn0st18m8zsT0yAegZ7RIhJDCowbC9J64B3HYQEKSXFEV7rpXS8iwvBv9cNy1Ip/k0oGNecs64ZXxT6uTrloBsmY7CTAmMbTU2Kd9pBMO3xyby33a3FzwRj1fJn1jHrGvaECvFIVrN6xIPTgDGuCEkvchXYn7eailpGkNjqh7g== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123564025)(20161123558021)(20161123560025)(20161123555025)(20161123562025)(2016111802025)(6072148)(6043046);SRVR:DB6PR0201MB2311;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0201MB2311; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0201MB2311;4:5sfBuv8ifZNEffeRQMAqFzLYBxL5EgbJoHm+1Ch5k+3f6RVVWlXoNxnHky+gkEZWyDcBuHEA56Y/uTtFP3GSYFpWjKdNwKaGS9MIZRmUwmdJcoCRWzGfA+ZdHs/VKRECg8SfbT4tJ3zYIXOfL+eqPEp07Tvlb/V7S0Oe8d0j6TeTVEKJ0IknH0c5r4dz/CXXksm4DWSmi18Aw75aly5KStadkAjIwHdcn4IrE7oa+Hs1l18RKvVajHTT8tJRsvGDuRzzj8sWtYh0z8l0SWo/eGvPZi5cJjmXaykbrbofAlk2bGx9Fb4soHyHNAKLz0EpariFYWOiMotUIJb19QxWEaZ9BDrKk01pILCk8OCGVOAOOUxUIcAwrmsF7DX7JKpa+27fyj0wfq+fHt0k1thgVweCiCJ0u1eTbAohODdwsm72mdsHxAApXd9shoMGWomd3Q4uEfb2Z8mMgWol6GMJPCXpM5ohe6RHmqGzHN4sISC0wFL6iDJapTjUGUXoSBygzLRCQz/vMHEqAAXcTMdIaVwaVF9YJTpb+W83i7Il9ulVsS92qIwAjt9k2zIbUWyJ26bXIlhfrp/arBnlhxz0rc6giLDYKwhe5IxfgYiTxZZ8jF8NbjR0O8SL0D6q/g9lXepUI8VTJ8w8VlZ8l2qUzx0rTXThL9jthA2GasFGQi0= X-Forefront-PRVS: 0157DEB61B X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(39410400002)(39830400002)(39450400003)(24454002)(199003)(189002)(377424004)(86362001)(7416002)(74482002)(6486002)(38730400001)(50466002)(2950100002)(83506001)(33646002)(64126003)(66066001)(5660300001)(101416001)(47776003)(77096006)(8676002)(54356999)(4001150100001)(105586002)(117156001)(81156014)(23746002)(90366009)(65826007)(81166006)(2906002)(4001350100001)(97736004)(68736007)(65956001)(76176999)(305945005)(189998001)(31686004)(42186005)(65806001)(92566002)(6116002)(110136003)(106356001)(229853002)(3846002)(36756003)(50986999)(31696002)(6666003)(230700001)(25786008)(7736002)(921003)(42262002)(1121003);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR0201MB2311;H:[192.168.0.125];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB6PR0201MB2311;23:gT1ImSl0Wt7JyF8W8Et65WtuNBkT9IGrPq6?= =?Windows-1252?Q?TY2EABR9ck7Ff8UEDihc4LPODDNoN58f+mca3/SGRBQlaht9YBmJXUCZ?= =?Windows-1252?Q?5CG6hpk2QrPsDAb7po/n+KjDkm14FjvZ44c3miT0SVNIJ5U2eiLxxySV?= =?Windows-1252?Q?8twqPBfyXXyUqF711zzPi5lqR45Czi5i2YHlUcAajFzw2T1M0rN02BUp?= =?Windows-1252?Q?azUiCJNYT1inSR3qfX0F1IkgmEbGOr6IZqOFJ86rrtwh3UBdRcXwY7lo?= =?Windows-1252?Q?UKmgWe5dpikyvlne9nu2WXrsrkBU8Gmp+NaZuu4ZZAKbKVpbnUBgKM6I?= =?Windows-1252?Q?Fp5GXEJsiSgMiP2t58uZyLopvHydVuyTkZutWdyFVNAbO0RTImmJY9iW?= =?Windows-1252?Q?VILbCsRz6ByL8wKnZ9dQ/oqSsmf8jf6Jg5K1E3wEolscgxABJUXPOqBp?= =?Windows-1252?Q?piQWmz1PQKdBR9GXwK5enZEtfZwJTKIWRdCuErI2s2li8wONtQgVc+RH?= =?Windows-1252?Q?y4W1AzCkekX3FSFLft+Fy9N2NiXaoMeHZGDb3j1fPyUM9gpwn6rjYstq?= =?Windows-1252?Q?rXvGdd1ktIMRrZ9djCNyC+yhVlWcl3e+S/JJ5JHsWNoFFQ6Y3JHLQv0h?= =?Windows-1252?Q?rPZIdGnmrVMp9nA75s7S1GsHCKW9AY9iCFp7o0F4eZ6mK8qb4kUtsb8R?= =?Windows-1252?Q?PiNsggpOxcMiTqYKtnNSW5NeU1Ifgr4w8sNSrUyeq7e1rG3WQL5ACSaO?= =?Windows-1252?Q?ivTA0EKtlsW2ryKBsTCncSm1kmTz5bYkmLClFNZ2MrW0/qclIAX2zQ3P?= =?Windows-1252?Q?zkF7dSii5dkZ59IGfUBceroVnUTjqB48BdzRS8AFPDOGo0qvf7KEl3Qt?= =?Windows-1252?Q?OF6oHEUksZYrGSn7h7QtoOS5B/bv2EN8A3bP7Q6bqmY1vpDdaXm1ipWQ?= =?Windows-1252?Q?SX//tt7IcIJThSxQbaJdD0luTXGXKvVxK+P+JOEpUxhwTtoXdh+4bGIK?= =?Windows-1252?Q?mCqdtwbvUIhBvkP6XApT7KIl8Sl3qeqZ8LxjehdVJDEC9h/M6BH8JAuZ?= =?Windows-1252?Q?kxkiJk8hj7TJ0lZVP+QRxxQzLM5QSKuUGT9+1hcdVZHOXaETvBrtbCHl?= =?Windows-1252?Q?F73T+XNEFk/6WK00Rm1r6xDfgunotoWgbmMeLxZb0mXTem2IjzUP0Btq?= =?Windows-1252?Q?lPXsuarA70pjRDCRdhsHgkdZNTdQFFu0PeiAaN0vr4FImbDWDQ0BmUm2?= =?Windows-1252?Q?Sb35v1RWunSe1LSj9y8o6+wyEqsIqqzUshRbYkGDJ/UWBSAcm6YR/X1O?= =?Windows-1252?Q?Mg2ctnG0q0KZ3QI8U3jl9AI2yMyk3s/eBciKhm7MdicUdGKrHFr0YHXL?= =?Windows-1252?Q?VC3BH6GzDET1WIm3ktWaZCIFA/jq9dOG3ssT+BlZFfAvXErMhvQZurqw?= =?Windows-1252?Q?HMkM8eAqzP30+WmP8/4H1ZqfdbXvjJyi4TUNccW9qqT4TzOi+fPHGI5l?= =?Windows-1252?Q?MfvvDfHBspkMa7Ul3XefpKRc91P2urcu4KgF0nwcLEWK0BU/Yhwfkf0a?= =?Windows-1252?Q?5h9HxQwhzoC/bkD0O1BzQCSd1HPa8ayA1xRAGzz559/5ANL3xkU0g886?= =?Windows-1252?Q?gwbwJ+yBgFolhds563AaMOxg=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0201MB2311;6:t9N+dyEDGKLe+7gR7+5GJPuEJuj1hYzPGzoroELi91MuOm5j9FER3IkrU/Ty081n4X29YnfMApgUe6xJscZdUIudocCFdXMt5BHDGITRLHoF5cEskpTyw88Ay4/EjNCc7j/ClQBiAwQiA4duc/LEic89eofnfDiu/vSemzKjichROoSZO2S+xGnE/uOjBHZskn3ZnjrYRdWN374S8Y4JK9OaHY7y0oAFHxW05cGWddTSfRAlK7MchMIkUtxpFPcLklpdUt6xWdTmHUsf+cTFZDNgdiIQ85VvdTFKB0cIMllehk/cpXZ5/sTvrTty7sU9tMfU1vkOm9tHT9uJuAxhIEi8/HsxqyuHlEkTLrAC07spDeXHUSYZwBLXnicOBHyferQWpN/5mw04GFsakRywCg+K9ycsg8pAdTSjQnP0nNXzb/BPuqxK3i6RrF+BD9Du;5:44/h/r0olHikwgZzmSUkNwNd24RFKcugFRu4B8CR+Jv6MyGf6Ktv+ebkLrd5xT3ipru1SW0qBgpCCT2Il7nDdaJVM6N7ax7ZmMhiAOCqHNTLQfUoBS3FMW2pa36yhDW2r0FRihMPd9ehgdFeUFwmLQ==;24:YY6hp7wf4eejhzLmGeHwSAjdY0TDWAIiNd7VYoZslZ+V5qOHxWGXkTf6wGpcBffxER1B4ULxVrMmihiYISbnY2K0bkjlJzYhFkW5DQG/wO8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR0201MB2311;7:7kEJSdZJ7eSOMnRLlLBqtW2KJPS7qxBzNMwdYZ9TDkwrOukqpA5NTfV1XvD0kH+tQpEd0dQm7uQt7kOwYhuMSsulmuUrRBtv1d20i2oOCL0/XJly5IXgJYtnp5MumtjxBa7NwFf++8228293chZolaiTR/joPxJzwIicOeWcs3TFO6j109Id2PwUNfDX/xhwfISJC1d31FjnewIv80pv2nMEQ/UXGv1uL0MnFpootBH+8xLUBm75cziQZEDFZIseBWz8OjmRMJUEvei7zaKSvlishyTVF6d8tWjrPir7LPduYvjtyHwpgtbgWrNBxHlo1ioldufaX36nchQuH3RDyYGXmHGN+Ospy7pB0kqa0TNHgi4q9aghAFXC96cybKh3Obi/9A9Qrm7Q4vCDYJAy3z2gOitF74jmhXpLTOzjStadQWhKunVScj20JBWbJyl8/I3LOCVrHNsZSL1S92PV6Q== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2016 15:17:09.5564 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0201MB2311 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 542 Lines: 16 On 2016-12-15 15:38, Luis Oliveira wrote: > diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/i2c-designware-core.h > index 26250b425e2f..3cb81fca7738 100644 > --- a/drivers/i2c/busses/i2c-designware-core.h > +++ b/drivers/i2c/busses/i2c-designware-core.h > @@ -36,7 +36,7 @@ > #define DW_IC_CON_SPEED_FAST 0x4 > #define DW_IC_CON_SPEED_HIGH 0x6 > #define DW_IC_CON_SPEED_MASK 0x6 > -#define DW_IC_CON_10BITADDR_MASTER 0x10 > +#define DW_IC_CON_10BITADDR_MASTER 0x10 How is this an improvement? Cheers, peda