Date: Thu, 15 Dec 2016 17:56:19 +0100
From: Petr Mladek <pmladek@suse.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: shuah@kernel.org, jeyu@redhat.com, rusty@rustcorp.com.au,
        ebiederm@xmission.com, dmitry.torokhov@gmail.com, acme@redhat.com,
        corbet@lwn.net, martin.wilck@suse.com, mmarek@suse.com, hare@suse.com,
        rwright@hpe.com, jeffm@suse.com, DSterba@suse.com, fdmanana@suse.com,
        neilb@suse.com, linux@roeck-us.net, rgoldwyn@suse.com,
        subashab@codeaurora.org, xypron.glpk@gmx.de, keescook@chromium.org,
        atomlin@redhat.com, mbenes@suse.cz, paulmck@linux.vnet.ibm.com,
        dan.j.williams@intel.com, jpoimboe@redhat.com, davem@davemloft.net,
        mingo@redhat.com, akpm@linux-foundation.org,
        torvalds@linux-foundation.org, linux-kselftest@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 09/10] kmod: add helpers for getting kmod count and limit
Message-ID: <20161215165619.GB18152@pathway.suse.cz>
References: <20161208184801.1689-1-mcgrof@kernel.org>
 <20161208194920.2768-1-mcgrof@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161208194920.2768-1-mcgrof@kernel.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 897
Lines: 24

On Thu 2016-12-08 11:49:20, Luis R. Rodriguez wrote:
> This adds helpers for getting access to the kmod count and limit from
> userspace. While at it, this also lets userspace fine tune the kmod
> limit after boot, it uses the shiny new proc_douintvec_minmax().
> 
> These knobs should help userspace more gracefully and deterministically
> handle module loading.
>
> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
> ---
>  include/linux/kmod.h |  8 +++++
>  kernel/kmod.c        | 83 ++++++++++++++++++++++++++++++++++++++++++++++++++--
>  kernel/sysctl.c      | 14 +++++++++
>  3 files changed, 103 insertions(+), 2 deletions(-)

I am not sure if it is worth it. As you say in the 3rd patch,
there was rather low limit for 16 years and nobody probably had
problems with it.

Anyway, it seems that such know should also get documented in
Documentation/sysctl/kernel.txt

Best Regards,
Petr