Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754630AbcLOSI4 (ORCPT ); Thu, 15 Dec 2016 13:08:56 -0500 Received: from mx2.suse.de ([195.135.220.15]:55915 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751455AbcLOSIy (ORCPT ); Thu, 15 Dec 2016 13:08:54 -0500 Date: Thu, 15 Dec 2016 19:08:46 +0100 From: "Luis R. Rodriguez" To: Linus Torvalds Cc: Martin Wilck , "Luis R. Rodriguez" , shuah@kernel.org, Jessica Yu , Rusty Russell , "Eric W. Biederman" , Dmitry Torokhov , Arnaldo Carvalho de Melo , Jonathan Corbet , martin.wilck@suse.com, Michal Marek , Petr Mladek , Hannes Reinecke , rwright@hpe.com, Jeff Mahoney , David Sterba , fdmanana@suse.com, NeilBrown , Guenter Roeck , Goldwyn Rodrigues , subashab@codeaurora.org, Heinrich Schuchardt , Kees Cook , atomlin@redhat.com, mbenes@suse.cz, Paul McKenney , Dan Williams , Josh Poimboeuf , David Miller , Ingo Molnar , Andrew Morton , linux-kselftest@vger.kernel.org, "open list:DOCUMENTATION" , Linux Kernel Mailing List Subject: Re: [RFC 10/10] kmod: add a sanity check on module loading Message-ID: <20161215180846.GA13946@wotan.suse.de> References: <20161208184801.1689-1-mcgrof@kernel.org> <20161208194930.2816-1-mcgrof@kernel.org> <1481313824.3358.38.camel@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1117 Lines: 28 On Fri, Dec 09, 2016 at 12:56:21PM -0800, Linus Torvalds wrote: > On Fri, Dec 9, 2016 at 12:03 PM, Martin Wilck wrote: > > On Thu, 2016-12-08 at 11:49 -0800, Luis R. Rodriguez wrote: > >> > >> Although this does get us in the business of keeping alias maps in > >> kernel, the the work to support and maintain this is trivial. > > > > You've implemented a special treatment for request_module("fs-$X")in > > finished_kmod_load(), but there are many more aliases defined (and > > used) in the kernel. Do you plan to implement special code for "char- > > major-$X", "crypto-$X", "binfmt-$X" etc. later? > > Yeah, no, that is just complete garbage. > > Those module aliases already exist in the module info section. We just > don't parse the alias tags in the kernel. > > So the real fix is to make find_module_all() just do that. Ah yes, that is much sexier, this is now done and it works nicely, thanks for the suggestion. > Doing random ad-hoc "let's prefix with 'fs-xyz'" games are completely > unacceptable. That's just pure shit. Stop this idiocy. Look at that fin DNA in action :) Luis