Date: Thu, 15 Dec 2016 19:08:46 +0100
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Martin Wilck <mwilck@suse.com>,
        "Luis R. Rodriguez" <mcgrof@kernel.org>, shuah@kernel.org,
        Jessica Yu <jeyu@redhat.com>, Rusty Russell <rusty@rustcorp.com.au>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>, martin.wilck@suse.com,
        Michal Marek <mmarek@suse.com>, Petr Mladek <pmladek@suse.com>,
        Hannes Reinecke <hare@suse.com>, rwright@hpe.com,
        Jeff Mahoney <jeffm@suse.com>, David Sterba <DSterba@suse.com>,
        fdmanana@suse.com, NeilBrown <neilb@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Goldwyn Rodrigues <rgoldwyn@suse.com>, subashab@codeaurora.org,
        Heinrich Schuchardt <xypron.glpk@gmx.de>,
        Kees Cook <keescook@chromium.org>, atomlin@redhat.com, mbenes@suse.cz,
        Paul McKenney <paulmck@linux.vnet.ibm.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        David Miller <davem@davemloft.net>, Ingo Molnar <mingo@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kselftest@vger.kernel.org,
        "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 10/10] kmod: add a sanity check on module loading
Message-ID: <20161215180846.GA13946@wotan.suse.de>
References: <20161208184801.1689-1-mcgrof@kernel.org>
 <20161208194930.2816-1-mcgrof@kernel.org>
 <1481313824.3358.38.camel@suse.com>
 <CA+55aFz49g9+cUZ0Z5BF84f619NHq+sx2pKttryXKhho1u1CBg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+55aFz49g9+cUZ0Z5BF84f619NHq+sx2pKttryXKhho1u1CBg@mail.gmail.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1117
Lines: 28

On Fri, Dec 09, 2016 at 12:56:21PM -0800, Linus Torvalds wrote:
> On Fri, Dec 9, 2016 at 12:03 PM, Martin Wilck <mwilck@suse.com> wrote:
> > On Thu, 2016-12-08 at 11:49 -0800, Luis R. Rodriguez wrote:
> >>
> >> Although this does get us in the business of keeping alias maps in
> >> kernel, the the work to support and maintain this is trivial.
> >
> > You've implemented a special treatment for request_module("fs-$X")in
> > finished_kmod_load(), but there are many more aliases defined (and
> > used) in the kernel. Do you plan to implement special code for "char-
> > major-$X", "crypto-$X", "binfmt-$X" etc. later?
> 
> Yeah, no, that is just complete garbage.
> 
> Those module aliases already exist in the module info section. We just
> don't parse the alias tags in the kernel.
> 
> So the real fix is to make find_module_all() just do that.

Ah yes, that is much sexier, this is now done and it works nicely, thanks
for the suggestion.

> Doing random ad-hoc "let's prefix with 'fs-xyz'" games are completely
> unacceptable. That's just pure shit. Stop this idiocy.

Look at that fin DNA in action :)

  Luis