Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754116AbcLOTdr (ORCPT ); Thu, 15 Dec 2016 14:33:47 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:54617 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752305AbcLOTdq (ORCPT ); Thu, 15 Dec 2016 14:33:46 -0500 Date: Thu, 15 Dec 2016 20:33:07 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: "M'boumba Cedric Madianga" Cc: Wolfram Sang , Rob Herring , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Patrice Chotard , linux@armlinux.org.uk, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 2/5] i2c: Add STM32F4 I2C driver Message-ID: <20161215193307.436sggu4zy4zezoe@pengutronix.de> References: <1481559342-6106-1-git-send-email-cedric.madianga@gmail.com> <1481559342-6106-3-git-send-email-cedric.madianga@gmail.com> <20161213092031.d2ax2pnpzzicriel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-06-11) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 842 Lines: 24 Hello Cedric, On Thu, Dec 15, 2016 at 04:26:25PM +0100, M'boumba Cedric Madianga wrote: > >> +static struct platform_driver stm32f4_i2c_driver = { > >> + .driver = { > >> + .name = "stm32f4-i2c", > >> + .of_match_table = stm32f4_i2c_match, > > > > Is this needed? > Without of_match_table, I could not match an I2C device instance from > DT with this driver. > So maybe, there is a misunderstanding. > Could you please clarify your question ? I thought (but I could be wrong) that if the driver is called "stm32f4-i2c", it is used to match "st,stm32f4-i2c" even without .of_match_table. If this doesn't work, please disregard my question. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |