Date: Thu, 15 Dec 2016 20:42:07 +0100
From: Wolfram Sang <wsa@the-dreams.de>
To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc: "M'boumba Cedric Madianga" <cedric.madianga@gmail.com>,
        robh+dt@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com,
        linus.walleij@linaro.org, patrice.chotard@st.com,
        linux@armlinux.org.uk, linux-i2c@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/5] i2c: Add STM32F4 I2C driver
Message-ID: <20161215194207.GB1741@katana>
References: <1481559342-6106-1-git-send-email-cedric.madianga@gmail.com>
 <1481559342-6106-3-git-send-email-cedric.madianga@gmail.com>
 <20161213092031.d2ax2pnpzzicriel@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="IiVenqGWf+H9Y6IX"
Content-Disposition: inline
In-Reply-To: <20161213092031.d2ax2pnpzzicriel@pengutronix.de>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1344
Lines: 39


--IiVenqGWf+H9Y6IX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


> > +	if (ret) {
> > +		dev_err(i2c_dev->dev, "bus not free\n");
> > +		ret =3D -EBUSY;
>=20
> I'm not sure if "bus not free" deserves an error message. Wolfram?

I tend to agree. But I never enforced it up to now, never found the time
to double check if I could/should enforce it.


--IiVenqGWf+H9Y6IX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJYUvIOAAoJEBQN5MwUoCm2U94P/jlXNnsX4eT1aH2J13k73rEP
nLMb9iHyoo51sJ8Nu8Hhq8ILFp46ROl9z5ZH7EmPrTeWBosu07RBAYxQxo4X/ufB
vsqxM/GKy7Z+wDSxWOzQKlgbgyO4zj6H/s1p+CsPidRvNoZ3D5D2PXWd6h5EvAId
8OGHhbACigdY6wMiv5iZQoZbtgCsxf37hhwz/zJBz4bK2owriAnYcnguTcaIKaeQ
AgwffZv8dkwF4Rubmc0H2MYETGtUP6t+Sr4GTx3mTx1IrRLT3Q2j28XoA8IkbSLD
u1CUYUyA+ukucPRWdN7b6up01djvtS63NWZhke1/QQWApasdjjEy4R52B+fqDE+a
Xg9zI2Xu0nG2NhoYFxxs1/LgVCGnoR2JPntkf6woqGJ0SFocR37SfFPk+My56H5z
VK6+RAX7inRpRGX/XI0/q2Q9NSWS/tm07I15TguehWWdPG8IonCehEK5oLOR8r0/
9iW12I06l3W865R428VkiZXeW23kOd/qlVHTsnodD9zXLfZeeaekH8XwSfZxVzZG
9KQ8a//lXdorTSLwNsJd/9Zg1rbctMnGhUMMkpL1HYDeSMqcOfu64zag3l8EOhIa
RGKrYb7K4rxzG8NaV1HLHw8pu9041rnZMXB88+YppBWUbceLZ4kPmv7esSLa6CHd
TcBA5U1AH8guhVYIkUzl
=aABL
-----END PGP SIGNATURE-----

--IiVenqGWf+H9Y6IX--