Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754309AbcLOUEF (ORCPT ); Thu, 15 Dec 2016 15:04:05 -0500 Received: from mx2.suse.de ([195.135.220.15]:42472 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753096AbcLOUED (ORCPT ); Thu, 15 Dec 2016 15:04:03 -0500 Date: Thu, 15 Dec 2016 21:03:24 +0100 From: Borislav Petkov To: Boris Ostrovsky Cc: Juergen Gross , Linux Kernel Mailing List , xen-devel Subject: Re: Can't boot as Xen dom0 due to commit fe055896 Message-ID: <20161215200324.6ju7o5e3aiirrycf@pd.tnic> References: <73a4d64b-b139-6579-a560-92311641d6c7@suse.com> <20161215164635.thm7ruio2ddnxszw@pd.tnic> <20161215171755.xpfuax7a6q3jofet@pd.tnic> <20161215173609.ornfok6lk5oro2pj@pd.tnic> <385ac3cd-7a3f-4c4d-69bb-8feee235fb7e@oracle.com> <20161215192305.dlgyrmteirgzop4y@pd.tnic> <399c758a-a94b-8aa1-efbb-79a0161b8020@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <399c758a-a94b-8aa1-efbb-79a0161b8020@oracle.com> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1060 Lines: 26 On Thu, Dec 15, 2016 at 02:36:46PM -0500, Boris Ostrovsky wrote: > We are calling find_proper_container(..., &eq_id) and determine result > based on eq_id not being zero. If find_proper_container() doesn't find > anything it will not modify eq_id and so you get back whatever you > passed in. The correct fix for that is to not return struct container at all from those functions but simply an eq_id or even an int error value or so. Passing back a struct is simply silly. I'll prep a proper patch for that. > The fact that I am having problems with HVM may or may not have > anything to do with microcode. I don't know yet but it's separate from > save_microcode_in_initrd_amd() patch. I am pretty sure about that > because unlike PV it is failing in early boot code. I still need a fix for Jürgen's use case where he lands in the microcode loader. And that he shouldn't do in the first place when running in a xen guest. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --