Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754524AbcLOVOU (ORCPT ); Thu, 15 Dec 2016 16:14:20 -0500 Received: from mail-it0-f66.google.com ([209.85.214.66]:33537 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752067AbcLOVOS (ORCPT ); Thu, 15 Dec 2016 16:14:18 -0500 MIME-Version: 1.0 In-Reply-To: References: <8ea3fdff-23c4-b81d-2588-44549bd2d8c1@stressinduktion.org> <063D6719AE5E284EB5DD2968C1650D6DB02401ED@AcuExch.aculab.com> <707472e1-b385-836d-c4c6-791c1dcc0776@stressinduktion.org> <063D6719AE5E284EB5DD2968C1650D6DB02402C0@AcuExch.aculab.com> <0f3c3694-c00b-aae2-5b08-25bc64bf6372@stressinduktion.org> <063D6719AE5E284EB5DD2968C1650D6DB0240437@AcuExch.aculab.com> <063D6719AE5E284EB5DD2968C1650D6DB0240529@AcuExch.aculab.com> <924ef794-eae0-2a6b-508b-069718339edc@stressinduktion.org> <20161215210933.GY3207@twins.programming.kicks-ass.net> From: Linus Torvalds Date: Thu, 15 Dec 2016 13:14:16 -0800 X-Google-Sender-Auth: MGGIraOc-wVtU7J3X4RUXrbPZeg Message-ID: Subject: Re: [kernel-hardening] Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function To: "Jason A. Donenfeld" Cc: "kernel-hardening@lists.openwall.com" , Hannes Frederic Sowa , David Laight , Netdev , Jean-Philippe Aumasson , LKML , Linux Crypto Mailing List , "Daniel J . Bernstein" , Eric Biggers Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 483 Lines: 13 On Thu, Dec 15, 2016 at 1:11 PM, Jason A. Donenfeld wrote: > > Indeed, I stand corrected. But in any case, the use of __aligned(8) in > the patchset ensures that things are fixed and that we don't have this > issue. I think you can/should just use the natural alignment for "u64". For architectures that need 8-byte alignment, u64 will already be properly aligned. For architectures (like x86-32) that only need 4-byte alignment, you get it. Linus