Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758920AbcLPB50 (ORCPT ); Thu, 15 Dec 2016 20:57:26 -0500 Received: from smtprelay0054.hostedemail.com ([216.40.44.54]:51787 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755838AbcLPB5R (ORCPT ); Thu, 15 Dec 2016 20:57:17 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2538:2553:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:6691:7514:7903:8957:10004:10400:10848:11232:11658:11914:12043:12663:12740:12760:12895:13069:13311:13357:13439:14096:14097:14181:14659:14721:14777:21080:21433:30022:30054:30060:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: hole05_3f2e5b7fbc800 X-Filterd-Recvd-Size: 2497 Message-ID: <1481853432.29291.76.camel@perches.com> Subject: Re: [PATCH] printk: Remove no longer used second struct cont From: Joe Perches To: Linus Torvalds , Sergey Senozhatsky Cc: Petr Mladek , Geert Uytterhoeven , Steven Rostedt , Mark Rutland , Andrew Morton , Linux Kernel Mailing List Date: Thu, 15 Dec 2016 17:57:12 -0800 In-Reply-To: References: <1481806438-30185-1-git-send-email-geert@linux-m68k.org> <20161215162336.GA18152@pathway.suse.cz> <20161216013706.GA20445@jagdpanzerIV.localdomain> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.1-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1243 Lines: 36 On Thu, 2016-12-15 at 17:50 -0800, Linus Torvalds wrote: > On Thu, Dec 15, 2016 at 5:37 PM, Sergey Senozhatsky > wrote: > > > > basically I'm talking about a bunch of 80-cols fixups. > > Please don't. > > Nobody uses a vt100 terminal any more. The 80-column wrapping is > excessive, and makes things like "grep" not work as well. > > No, we still don't want excessively long lines, but that's generally > mainly because > > (a) we don't want to have excessively _complicated_ lines > > (b) we don't want to have excessively deep indentation (so if line > length is due to 4+ levels of indentation, that's usually the primary > problem). > > (c) email quoting gets iffier and uglier, so short lines always are > preferred if possible > > but in general, aside from those concerns, a long legible line is > generally preferred over just adding line breaks for the very > _occasional_ line. > > At the 100-column mark you almost have to break, because at that point > people may start to be actually limited by their displays, but 80 > columns generally isn't it. > > In fact, I thought we already upped the check-patch limit to 100? Nope, CodingStyle neither. Last time I tried was awhile ago.