Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758990AbcLPCLV (ORCPT ); Thu, 15 Dec 2016 21:11:21 -0500 Received: from mail-io0-f193.google.com ([209.85.223.193]:36377 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758881AbcLPCLP (ORCPT ); Thu, 15 Dec 2016 21:11:15 -0500 MIME-Version: 1.0 In-Reply-To: <1481853432.29291.76.camel@perches.com> References: <1481806438-30185-1-git-send-email-geert@linux-m68k.org> <20161215162336.GA18152@pathway.suse.cz> <20161216013706.GA20445@jagdpanzerIV.localdomain> <1481853432.29291.76.camel@perches.com> From: Linus Torvalds Date: Thu, 15 Dec 2016 18:10:59 -0800 X-Google-Sender-Auth: yLCH65h4EMtJiA7pXqdgydgJyNk Message-ID: Subject: Re: [PATCH] printk: Remove no longer used second struct cont To: Joe Perches Cc: Sergey Senozhatsky , Petr Mladek , Geert Uytterhoeven , Steven Rostedt , Mark Rutland , Andrew Morton , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1302 Lines: 34 On Thu, Dec 15, 2016 at 5:57 PM, Joe Perches wrote: >> >> In fact, I thought we already upped the check-patch limit to 100? > > Nope, CodingStyle neither. > > Last time I tried was awhile ago. Ok, it must have been just talked about, and with the exceptions for strings etc I may not have seen as many of the really annoying line breaks lately. I don't mind a 80-column "soft limit" per se: if some code consistently goes over 80 columns, there really is something seriously wrong there. So 80 columns may well be the right limit for that kind of check (or even less). But if we have just a couple of lines that are longer (in a file that is 3k+ lines), I'd rather not break those. I tend use "git grep" a lot, and it's much easier to see function argument use if it's all on one line. Of course, some function calls really are *so* long that they have to be broken up, but that's where the "if it's a couple of lines that go a bit over the 80 column limit..." exception basically comes in. Put another way: long lines definitely aren't good. But breaking long lines has some downsides too, so there should be a balance between the two, rather than some black-and-white limit. In fact, we've seldom had cases where black-and-white limits work well. Linus