Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758908AbcLPED5 (ORCPT ); Thu, 15 Dec 2016 23:03:57 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:20599 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753105AbcLPEDw (ORCPT ); Thu, 15 Dec 2016 23:03:52 -0500 Date: Thu, 15 Dec 2016 22:03:19 -0600 From: Bin Liu To: Pali =?iso-8859-1?Q?Roh=E1r?= CC: Greg Kroah-Hartman , , , Tony Lindgren , joerg Reisenweber , , Ivaylo Dimitrov , Sebastian Reichel , Aaro Koskinen , Pavel Machek , Nishanth Menon , Felipe Balbi Subject: Re: [PATCH] usb: musb: debugfs: allow forcing host mode together with speed in testmode Message-ID: <20161216040319.GA18350@uda0271908> Mail-Followup-To: Bin Liu , Pali =?iso-8859-1?Q?Roh=E1r?= , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Tony Lindgren , joerg Reisenweber , linux-omap@vger.kernel.org, Ivaylo Dimitrov , Sebastian Reichel , Aaro Koskinen , Pavel Machek , Nishanth Menon , Felipe Balbi References: <1481726877-18548-1-git-send-email-pali.rohar@gmail.com> <1481743425-25847-1-git-send-email-pali.rohar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1481743425-25847-1-git-send-email-pali.rohar@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1304 Lines: 39 On Wed, Dec 14, 2016 at 08:23:45PM +0100, Pali Roh?r wrote: > Based on the musb ug, force_host bit is allowed to be set along with > force_hs or force_fs bit. > > It could help to implement forced host mode via testmode on Nokia N900. > > Signed-off-by: Pali Roh?r > --- > drivers/usb/musb/musb_debugfs.c | 44 +++++++++++++++++++++++++-------------- > 1 file changed, 28 insertions(+), 16 deletions(-) > > diff --git a/drivers/usb/musb/musb_debugfs.c b/drivers/usb/musb/musb_debugfs.c > index 9b22d94..62c13a2 100644 > --- a/drivers/usb/musb/musb_debugfs.c > +++ b/drivers/usb/musb/musb_debugfs.c > @@ -147,28 +147,34 @@ static int musb_test_mode_show(struct seq_file *s, void *unused) > > test = musb_readb(musb->mregs, MUSB_TESTMODE); > > - if (test & MUSB_TEST_FORCE_HOST) > + if (test & (MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_FS)) if (test & (MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_FS) == MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_FS) or even simpler: if (test == MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_FS) since multiple tests at the same time are not allowed. > + seq_printf(s, "force host full-speed\n"); > + > + else if (test & (MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_HS)) else if (test == MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_HS) Regards, -Bin.