From: Jerry Huang <jerry.huang@nxp.com>
To: Jerry Huang <jerry.huang@nxp.com>,
        "balbi@kernel.org" <balbi@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Rajesh Bhagat <rajesh.bhagat@nxp.com>
Subject: RE: [PATCH] USB3/DWC3: Enable undefined length INCR burst type
Thread-Topic: [PATCH] USB3/DWC3: Enable undefined length INCR burst type
Thread-Index: AQHSVSKUGATAu7bkYUajSqFxHuv8nqEJ6Hqg
Date: Fri, 16 Dec 2016 03:07:07 +0000
Message-ID: <DB5PR0401MB1813A701FA460CA2D5C19C4FFE9C0@DB5PR0401MB1813.eurprd04.prod.outlook.com>
References: <1481619983-4782-1-git-send-email-jerry.huang@nxp.com>
In-Reply-To: <1481619983-4782-1-git-send-email-jerry.huang@nxp.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2016 03:07:07.6076
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0401MB1814
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uBG5ifHf022791
Content-Length: 2570
Lines: 65


> -----Original Message-----
> From: Changming Huang [mailto:jerry.huang@nxp.com]
> Sent: Tuesday, December 13, 2016 5:06 PM
> To: balbi@kernel.org; gregkh@linuxfoundation.org
> Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Jerry Huang
> <jerry.huang@nxp.com>; Rajesh Bhagat <rajesh.bhagat@nxp.com>
> Subject: [PATCH] USB3/DWC3: Enable undefined length INCR burst type
> 
> While enabling undefined length INCR burst type and INCR16 burst type, get
> better write performance on NXP Layerscape platform:
> around 3% improvement (from 364MB/s to 375MB/s).
> 
> Signed-off-by: Changming Huang <jerry.huang@nxp.com>
> Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>
> ---
>  drivers/usb/dwc3/core.c |    6 ++++++
>  drivers/usb/dwc3/core.h |   13 +++++++++++++
>  2 files changed, 19 insertions(+)
> 
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index
> fea4469..0e11891 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -621,6 +621,12 @@ static int dwc3_core_init(struct dwc3 *dwc)
>  		goto err0;
>  	}
> 
> +	/* Enable Undefined Length INCR Burst Type and Enable INCR16
> Burst */
> +	reg = dwc3_readl(dwc->regs, DWC3_GSBUSCFG0);
> +	reg &= ~DWC3_GSBUSCFG0_INCRBRSTMASK;
> +	reg |= DWC3_GSBUSCFG0_INCR16BRSTENA |
> DWC3_GSBUSCFG0_INCRBRSTENA;
> +	dwc3_writel(dwc->regs, DWC3_GSBUSCFG0, reg);
> +
>  	/*
>  	 * Write Linux Version Code to our GUID register so it's easy to figure
>  	 * out which kernel version a bug was found.
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index
> 6b60e42..8bfdb77 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -156,6 +156,19 @@
> 
>  /* Bit fields */
> 
> +/* Global SoC Bus Configuration Register 0 */
> +#define DWC3_GSBUSCFG0_DATABIGEND	(1 << 11)
> +#define DWC3_GSBUSCFG0_DESCBIGEND	(1 << 10)
> +#define DWC3_GSBUSCFG0_INCR256BRSTENA	(1 << 7)
> +#define DWC3_GSBUSCFG0_INCR128BRSTENA	(1 << 6)
> +#define DWC3_GSBUSCFG0_INCR64BRSTENA	(1 << 5)
> +#define DWC3_GSBUSCFG0_INCR32BRSTENA	(1 << 4)
> +#define DWC3_GSBUSCFG0_INCR16BRSTENA	(1 << 3)
> +#define DWC3_GSBUSCFG0_INCR8BRSTENA	(1 << 2)
> +#define DWC3_GSBUSCFG0_INCR4BRSTENA	(1 << 1)
> +#define DWC3_GSBUSCFG0_INCRBRSTENA	(1 << 0)
> +#define DWC3_GSBUSCFG0_INCRBRSTMASK	0xff
> +
>  /* Global Debug Queue/FIFO Space Available Register */
>  #define DWC3_GDBGFIFOSPACE_NUM(n)	((n) & 0x1f)
>  #define DWC3_GDBGFIFOSPACE_TYPE(n)	(((n) << 5) & 0x1e0)
> --
I will split this patch to two, one is for the performance tune, the other for macro definition in header file.