Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760223AbcLPJ3I (ORCPT ); Fri, 16 Dec 2016 04:29:08 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:39185 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754882AbcLPJ26 (ORCPT ); Fri, 16 Dec 2016 04:28:58 -0500 Subject: Re: [PATCH] ARM: imx: remove unused device definitions To: Arnd Bergmann References: <20161216090533.2195228-1-arnd@arndb.de> <7e077d23-eec1-6a6a-9318-84a5543d684d@pengutronix.de> <3673316.UJiiIZbYgE@wuerfel> Cc: Shawn Guo , linux-kernel@vger.kernel.org, Sascha Hauer , Fabio Estevam , Alexander Kurz , linux-arm-kernel@lists.infradead.org From: Marc Kleine-Budde Message-ID: Date: Fri, 16 Dec 2016 10:28:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <3673316.UJiiIZbYgE@wuerfel> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8vc8tNDdn3q7tviSc7PuG8sQBMFngsqPb" X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3623 Lines: 95 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8vc8tNDdn3q7tviSc7PuG8sQBMFngsqPb Content-Type: multipart/mixed; boundary="s1mnKGhjsVEd89hw6eMcSprT749NbIjmM"; protected-headers="v1" From: Marc Kleine-Budde To: Arnd Bergmann Cc: Shawn Guo , linux-kernel@vger.kernel.org, Sascha Hauer , Fabio Estevam , Alexander Kurz , linux-arm-kernel@lists.infradead.org Message-ID: Subject: Re: [PATCH] ARM: imx: remove unused device definitions References: <20161216090533.2195228-1-arnd@arndb.de> <7e077d23-eec1-6a6a-9318-84a5543d684d@pengutronix.de> <3673316.UJiiIZbYgE@wuerfel> In-Reply-To: <3673316.UJiiIZbYgE@wuerfel> --s1mnKGhjsVEd89hw6eMcSprT749NbIjmM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/16/2016 10:23 AM, Arnd Bergmann wrote: > On Friday, December 16, 2016 10:10:49 AM CET Marc Kleine-Budde wrote: >> On 12/16/2016 10:05 AM, Arnd Bergmann wrote: >>> I stumbled over these during build testing, they are evidently >>> not referenced anywhere any more. >>> >>> Signed-off-by: Arnd Bergmann >>> --- >>> arch/arm/mach-imx/devices/platform-flexcan.c | 9 --------- >>> arch/arm/mach-imx/devices/platform-sdhci-esdhc-imx.c | 10 ----------= >>> 2 files changed, 19 deletions(-) >>> >>> diff --git a/arch/arm/mach-imx/devices/platform-flexcan.c b/arch/arm/= mach-imx/devices/platform-flexcan.c >>> index 55d61eaf63c6..8a1a2fc4ce10 100644 >>> --- a/arch/arm/mach-imx/devices/platform-flexcan.c >>> +++ b/arch/arm/mach-imx/devices/platform-flexcan.c >>> @@ -19,15 +19,6 @@ >>> #define imx_flexcan_data_entry(soc, _id, _hwid, _size) \ >>> [_id] =3D imx_flexcan_data_entry_single(soc, _id, _hwid, _size) >>> =20 >>> -#ifdef CONFIG_SOC_IMX25 >>> -const struct imx_flexcan_data imx25_flexcan_data[] __initconst =3D {= >>> -#define imx25_flexcan_data_entry(_id, _hwid) \ >>> - imx_flexcan_data_entry(MX25, _id, _hwid, SZ_16K) >>> - imx25_flexcan_data_entry(0, 1), >>> - imx25_flexcan_data_entry(1, 2), >>> -}; >>> -#endif /* ifdef CONFIG_SOC_IMX25 */ >>> - >>> #ifdef CONFIG_SOC_IMX35 >>> const struct imx_flexcan_data imx35_flexcan_data[] __initconst =3D {= >>> #define imx35_flexcan_data_entry(_id, _hwid) \ >> >> What about the imx35 variant? >> >=20 > It's used from here: >=20 > arch/arm/mach-imx/mach-pcm043.c: imx35_add_flexcan1(); Yes, you're right. Sorry, I searched before my 2nd tee. Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --s1mnKGhjsVEd89hw6eMcSprT749NbIjmM-- --8vc8tNDdn3q7tviSc7PuG8sQBMFngsqPb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEES2FAuYbJvAGobdVQPTuqJaypJWoFAlhTs9AACgkQPTuqJayp JWo3vgf+L3qX0ZSijx3KEiFjB/U65IGU5InbCYpMSJ2m7Zbf1ttewxxwoZteb848 txmGo55LRMIyYTpAu4q8GkWQGpvREL8XxQz7CP+4TDm7XkDttYn41Onmx6+MuEYj VDpiUhDusQMIfacbwq6xoa45vGNlw0Min3KdKq4vw5nk2DLhDfZ2cuw3eV4yMXTb ZMPqTk4eMJxr4OnHYdEXsWnLWF/HQ4hX9TKX3PGduU3IlHheWvk3T+CtJcTsMOfo 4tkAz9Umx7K8j1JVS6nHakkZbMEkqQ8KJMpPOq1QpK5tADjrNJb8Zp9VSf+x2MO0 n+zawwxsyTWNFlMlA5YjQbnZf/17zA== =KZ+3 -----END PGP SIGNATURE----- --8vc8tNDdn3q7tviSc7PuG8sQBMFngsqPb--