Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760100AbcLPKnE (ORCPT ); Fri, 16 Dec 2016 05:43:04 -0500 Received: from mail-wj0-f195.google.com ([209.85.210.195]:34616 "EHLO mail-wj0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754964AbcLPKmy (ORCPT ); Fri, 16 Dec 2016 05:42:54 -0500 Date: Fri, 16 Dec 2016 11:36:15 +0100 From: Michal Hocko To: Vegard Nossum Cc: "Kirill A. Shutemov" , Peter Zijlstra , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Rik van Riel , Matthew Wilcox , Andrew Morton , Al Viro , Ingo Molnar , Linus Torvalds Subject: Re: [PATCH 1/4] mm: add new mmgrab() helper Message-ID: <20161216103615.GF13940@dhcp22.suse.cz> References: <20161216082202.21044-1-vegard.nossum@oracle.com> <20161216095624.GR3107@twins.programming.kicks-ass.net> <20161216101915.GC27758@node> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 649 Lines: 23 On Fri 16-12-16 11:20:40, Vegard Nossum wrote: > On 12/16/2016 11:19 AM, Kirill A. Shutemov wrote: > > On Fri, Dec 16, 2016 at 10:56:24AM +0100, Peter Zijlstra wrote: > > > But I must say mmget() vs mmgrab() is a wee bit confusing. > > > > mm_count vs mm_users is not very clear too. :) > > > > I was about to say, I'm not sure it's much better than mmput() vs > mmdrop() or mm_users vs mm_count either, although the way I rationalised > it was the 3 vs 4 letters: > > mmget() -- mmgrab() > mmput() -- mmdrop() > ^^^ 3 ^^^^ 4 get -> put grab -> drop makes sense to me... No idea about a much more clear name. -- Michal Hocko SUSE Labs