Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759865AbcLPLt2 (ORCPT ); Fri, 16 Dec 2016 06:49:28 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36602 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934636AbcLPLrG (ORCPT ); Fri, 16 Dec 2016 06:47:06 -0500 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Tony Lindgren , Javier Martinez Canillas Subject: Re: [PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE in case DT does not provide /chosen/bootargs Date: Fri, 16 Dec 2016 12:46:12 +0100 User-Agent: KMail/1.13.7 (Linux/3.13.0-105-generic; KDE/4.14.2; x86_64; ; ) Cc: "Russell King - ARM Linux" , Arnd Bergmann , Robin Murphy , Linus Walleij , Ben Dooks , Ivaylo Dimitrov , Sebastian Reichel , Aaro Koskinen , Pavel Machek , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1481749963-8664-1-git-send-email-pali.rohar@gmail.com> <20161214235224.GH14217@n2100.armlinux.org.uk> <201612150109.20868@pali> In-Reply-To: <201612150109.20868@pali> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1847261.DPF146Gxjq"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201612161246.12155@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2106 Lines: 56 --nextPart1847261.DPF146Gxjq Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Thursday 15 December 2016 01:09:20 Pali Roh=C3=A1r wrote: > On Thursday 15 December 2016 00:52:24 Russell King - ARM Linux wrote: > > On Wed, Dec 14, 2016 at 10:12:43PM +0100, Pali Roh=C3=A1r wrote: > > > Commit 008a2ebcd677 ("ARM: dts: omap3: Remove skeleton.dtsi > > > usage") broke support for setting cmdline on Nokia N900 via > > > CONFIG_CMDLINE. > > >=20 > > > It is because arm code booted in DT mode parse cmdline only via > > > function early_init_dt_scan_chosen() and that function does not > > > fill variable boot_command_line when DTB does not contain /chosen > > > entry. It is called from function early_init_dt_scan_nodes() in > > > setup_machine_fdt(). > > >=20 > > > This patch fixes it by explicitly filling boot_command_line in > > > function setup_machine_fdt() after calling > > > early_init_dt_scan_nodes() in case boot_command_line still > > > remains empty. > >=20 > > This looks like a hack. > >=20 > > First, the matter of the ATAGs compatibility. The decompressor > > relies on there being a pre-existing /chosen node to insert the > > command line and other parameters into. If we've dropped it (by > > dropping skeleton.dtsi) then we've just regressed more than just > > N900 - the decompressor won't be able to merge the ATAGs into the > > concatenated FDT. >=20 > Hm... I did not think about it. But right this can be broken too... Tony, Javier: are you aware of above =E2=86=91=E2=86=91=E2=86=91 problem? It looks like commit 008a2ebcd677 ("ARM: dts: omap3: Remove=20 skeleton.dtsi usage") should be really reverted. =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart1847261.DPF146Gxjq Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlhT1AQACgkQi/DJPQPkQ1JEhACgq70NL5/Ggl5POoYRrpKlYPwu xV8AmwY6kGwObc4YssQkrR55JXsBMkkg =y0Uu -----END PGP SIGNATURE----- --nextPart1847261.DPF146Gxjq--