Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759500AbcLPLws (ORCPT ); Fri, 16 Dec 2016 06:52:48 -0500 Received: from mail.kernel.org ([198.145.29.136]:43578 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755003AbcLPLwi (ORCPT ); Fri, 16 Dec 2016 06:52:38 -0500 Date: Fri, 16 Dec 2016 20:52:21 +0900 From: Masami Hiramatsu To: Anju T Sudhakar Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, ananth@in.ibm.com, naveen.n.rao@linux.vnet.ibm.com, paulus@samba.org, srikar@linux.vnet.ibm.com, benh@kernel.crashing.org, mpe@ellerman.id.au, mahesh@linux.vnet.ibm.com, mhiramat@kernel.org Subject: Re: [PATCH V2 2/4] powerpc: add helper to check if offset is within rel branch range Message-Id: <20161216205221.b6368901a9eea6a8cb7a84ff@kernel.org> In-Reply-To: <1481732310-7779-5-git-send-email-anju@linux.vnet.ibm.com> References: <1481732310-7779-1-git-send-email-anju@linux.vnet.ibm.com> <1481732310-7779-5-git-send-email-anju@linux.vnet.ibm.com> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2856 Lines: 80 On Wed, 14 Dec 2016 21:48:30 +0530 Anju T Sudhakar wrote: > From: "Naveen N. Rao" > The coding is OK to me. Please add a description for this patch here, e.g. what is done by this patch, what kind of branch instruction will be covered, and why thse checks are needed etc. Thank you, > Signed-off-by: Naveen N. Rao > Signed-off-by: Anju T Sudhakar > --- > arch/powerpc/include/asm/code-patching.h | 1 + > arch/powerpc/lib/code-patching.c | 24 +++++++++++++++++++++++- > 2 files changed, 24 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/include/asm/code-patching.h b/arch/powerpc/include/asm/code-patching.h > index 2015b07..75ee4f4 100644 > --- a/arch/powerpc/include/asm/code-patching.h > +++ b/arch/powerpc/include/asm/code-patching.h > @@ -22,6 +22,7 @@ > #define BRANCH_SET_LINK 0x1 > #define BRANCH_ABSOLUTE 0x2 > > +bool is_offset_in_branch_range(long offset); > unsigned int create_branch(const unsigned int *addr, > unsigned long target, int flags); > unsigned int create_cond_branch(const unsigned int *addr, > diff --git a/arch/powerpc/lib/code-patching.c b/arch/powerpc/lib/code-patching.c > index d5edbeb..f643451 100644 > --- a/arch/powerpc/lib/code-patching.c > +++ b/arch/powerpc/lib/code-patching.c > @@ -32,6 +32,28 @@ int patch_branch(unsigned int *addr, unsigned long target, int flags) > return patch_instruction(addr, create_branch(addr, target, flags)); > } > > +bool is_offset_in_branch_range(long offset) > +{ > + /* > + * Powerpc branch instruction is : > + * > + * 0 6 30 31 > + * +---------+----------------+---+---+ > + * | opcode | LI |AA |LK | > + * +---------+----------------+---+---+ > + * Where AA = 0 and LK = 0 > + * > + * LI is a signed 24 bits integer. The real branch offset is computed > + * by: imm32 = SignExtend(LI:'0b00', 32); > + * > + * So the maximum forward branch should be: > + * (0x007fffff << 2) = 0x01fffffc = 0x1fffffc > + * The maximum backward branch should be: > + * (0xff800000 << 2) = 0xfe000000 = -0x2000000 > + */ > + return (offset >= -0x2000000 && offset <= 0x1fffffc && !(offset & 0x3)); > +} > + > unsigned int create_branch(const unsigned int *addr, > unsigned long target, int flags) > { > @@ -43,7 +65,7 @@ unsigned int create_branch(const unsigned int *addr, > offset = offset - (unsigned long)addr; > > /* Check we can represent the target in the instruction format */ > - if (offset < -0x2000000 || offset > 0x1fffffc || offset & 0x3) > + if (!is_offset_in_branch_range(offset)) > return 0; > > /* Mask out the flags and target, so they don't step on each other. */ > -- > 2.7.4 > -- Masami Hiramatsu