Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761032AbcLPPZV (ORCPT ); Fri, 16 Dec 2016 10:25:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55514 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755677AbcLPPZO (ORCPT ); Fri, 16 Dec 2016 10:25:14 -0500 Subject: Re: [PATCH v2 2/6] KVM: x86: decouple irqchip_in_kernel() and pic_irqchip() To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <20161216151006.11776-1-rkrcmar@redhat.com> <20161216151006.11776-3-rkrcmar@redhat.com> From: Paolo Bonzini Message-ID: Date: Fri, 16 Dec 2016 16:25:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161216151006.11776-3-rkrcmar@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 16 Dec 2016 15:25:13 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 372 Lines: 18 On 16/12/2016 16:10, Radim Krčmář wrote: > + bool ret = irqchip_kernel(kvm) || irqchip_split(kvm); bool ret = (kvm->arch.irqchip_mode != KVM_IRQCHIP_NONE); :) Paolo > > - ret = (vpic != NULL); > - ret |= irqchip_split(kvm); > - > - /* Read vpic before kvm->irq_routing. */ > + /* Matches with wmb after initializing kvm->irq_routing. */ > smp_rmb();