Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761792AbcLPPoP (ORCPT ); Fri, 16 Dec 2016 10:44:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50218 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754718AbcLPPoI (ORCPT ); Fri, 16 Dec 2016 10:44:08 -0500 Date: Fri, 16 Dec 2016 16:44:05 +0100 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v2 2/6] KVM: x86: decouple irqchip_in_kernel() and pic_irqchip() Message-ID: <20161216154404.GA3637@potion> References: <20161216151006.11776-1-rkrcmar@redhat.com> <20161216151006.11776-3-rkrcmar@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 16 Dec 2016 15:44:08 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 396 Lines: 12 2016-12-16 16:25+0100, Paolo Bonzini: > On 16/12/2016 16:10, Radim Krčmář wrote: >> + bool ret = irqchip_kernel(kvm) || irqchip_split(kvm); > > bool ret = (kvm->arch.irqchip_mode != KVM_IRQCHIP_NONE); > > :) (That imposes an assumption that we will only add in-kernel irqchips! Are we willing to sell our souls for faster code? :]) I'll use that line without parentheses, thanks.