Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934315AbcLPQN5 (ORCPT ); Fri, 16 Dec 2016 11:13:57 -0500 Received: from mail-wj0-f193.google.com ([209.85.210.193]:36361 "EHLO mail-wj0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932462AbcLPQNu (ORCPT ); Fri, 16 Dec 2016 11:13:50 -0500 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Tony Lindgren Subject: Re: [PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE in case DT does not provide /chosen/bootargs Date: Fri, 16 Dec 2016 17:13:46 +0100 User-Agent: KMail/1.13.7 (Linux/3.13.0-105-generic; KDE/4.14.2; x86_64; ; ) Cc: Javier Martinez Canillas , "Russell King - ARM Linux" , Arnd Bergmann , Robin Murphy , Linus Walleij , Ben Dooks , Ivaylo Dimitrov , Sebastian Reichel , Aaro Koskinen , Pavel Machek , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1481749963-8664-1-git-send-email-pali.rohar@gmail.com> <1b779429-8ce4-a49b-38e4-573b28a7c05f@osg.samsung.com> <20161216154029.GF4920@atomide.com> In-Reply-To: <20161216154029.GF4920@atomide.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1758066.Vp8pIEcgjk"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201612161713.46770@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2078 Lines: 56 --nextPart1758066.Vp8pIEcgjk Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Friday 16 December 2016 16:40:30 Tony Lindgren wrote: > * Javier Martinez Canillas [161216 04:54]: > > On 12/16/2016 09:48 AM, Pali Roh=C3=A1r wrote: > > >>> saying that it cause problems which need to be properly fixed. > > >>> And if fixing them is harder and will take more time, then > > >>> correct option is to revert 008a2ebcd677 due to breaking > > >>> support for more devices. > > >>=20 > > >> If you think that others boards may have the same issue, then > > >> you could add an empty chosen node to omap3.dtsi. As I said I > > >> think that in practice this will only be needed for the > > >> machines using NOLO but you are right that in theory you could > > >> boot them using other bootloaders and having an empty node > > >> doesn't cause any harm anyway. > > >=20 > > > Should not be it part of any arm board? IIRC ATAG support is (or > > > was) not omap3 specified. > >=20 > > Yes, but you were talking about commit 008a2ebcd677 which only > > removed skeleton.dtsi usage for OMAP3 boards. The same can be done > > for other SoCs in its top level dtsi for the SoC family of course. >=20 > Yeah probaby best to add the empty chosen node to the ones that had > skeleton.dtsi removed. Ok. But still I think that it should be added globally to all arm board=20 which can be booted by ATAG bootloader. > And I think the code should print a warning if no chosen node is > found? Which code? Decompressor? Yes, it should but I do not know if at that=20 time is (serial) console usable... =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart1758066.Vp8pIEcgjk Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlhUEroACgkQi/DJPQPkQ1IyIgCgyiLqo0T4iUZ7vbsA/Xzg+UrK f28AoJUdq9IBwR2tQyD2Is/Nk9dAYxat =OkeS -----END PGP SIGNATURE----- --nextPart1758066.Vp8pIEcgjk--