Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758621AbcLPSVU (ORCPT ); Fri, 16 Dec 2016 13:21:20 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:48336 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757665AbcLPSU5 (ORCPT ); Fri, 16 Dec 2016 13:20:57 -0500 Date: Fri, 16 Dec 2016 10:20:45 -0800 From: Darren Hart To: Andy Shevchenko Cc: Irina Tirdea , linux-clk@vger.kernel.org, "x86@kernel.org" , platform-driver-x86@vger.kernel.org, Stephen Boyd , Thomas Gleixner , Michael Turquette , Ingo Molnar , "H. Peter Anvin" , ALSA Development Mailing List , Mark Brown , Takashi Iwai , Pierre-Louis Bossart , "Rafael J. Wysocki" , Len Brown , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v6 2/3] arch/x86/platform/atom: Move pmc_atom to drivers/platform/x86 Message-ID: <20161216182045.GA44199@f23x64.localdomain> References: <1481306510-7471-1-git-send-email-irina.tirdea@intel.com> <1481306510-7471-3-git-send-email-irina.tirdea@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1623 Lines: 40 On Tue, Dec 13, 2016 at 01:43:31AM +0200, Andy Shevchenko wrote: > I have been told I have to send my comments here instead of our > internal ML. I didn't fast enough to comment that during v5. So do it > right now. > > On Fri, Dec 9, 2016 at 8:01 PM, Irina Tirdea wrote: > > The pmc_atom driver does not contain any architecture specific > > code. It only enables the SOC Power Management Controller Driver > > SOC -> SoC > Driver -> driver > > > for BayTrail and CherryTrail platforms. > > > > Move the pmc_atom driver from arch/x86/platform/atom to > > drivers/platform/x86. > > > > Signed-off-by: Irina Tirdea > > --- > > arch/x86/Kconfig | 4 ---- > > arch/x86/platform/atom/Makefile | 1 - > > drivers/acpi/acpi_lpss.c | 2 +- > > drivers/platform/x86/Kconfig | 4 ++++ > > drivers/platform/x86/Makefile | 1 + > > {arch/x86/platform/atom => drivers/platform/x86}/pmc_atom.c | 3 +-- > > > {arch/x86/include/asm => include/linux/platform_data/x86}/pmc_atom.h | 0 > > No, it's not a *platform data*. > > Other that that looks good to me. Where would you recommend instead? It needs a place to serve both acpi_lpss.c and pmc_atom.c. The include/linux/platform_data/x86 location doesn't seem too strange as it supports a "platform" driver in the sense that pmc_atom is a platform driver. -- Darren Hart Intel Open Source Technology Center