Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759183AbcLPSje (ORCPT ); Fri, 16 Dec 2016 13:39:34 -0500 Received: from mail-oi0-f68.google.com ([209.85.218.68]:33710 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933001AbcLPSjD (ORCPT ); Fri, 16 Dec 2016 13:39:03 -0500 MIME-Version: 1.0 In-Reply-To: <20161216182045.GA44199@f23x64.localdomain> References: <1481306510-7471-1-git-send-email-irina.tirdea@intel.com> <1481306510-7471-3-git-send-email-irina.tirdea@intel.com> <20161216182045.GA44199@f23x64.localdomain> From: Andy Shevchenko Date: Fri, 16 Dec 2016 20:39:01 +0200 Message-ID: Subject: Re: [PATCH v6 2/3] arch/x86/platform/atom: Move pmc_atom to drivers/platform/x86 To: Darren Hart Cc: Irina Tirdea , linux-clk@vger.kernel.org, "x86@kernel.org" , platform-driver-x86@vger.kernel.org, Stephen Boyd , Thomas Gleixner , Michael Turquette , Ingo Molnar , "H. Peter Anvin" , ALSA Development Mailing List , Mark Brown , Takashi Iwai , Pierre-Louis Bossart , "Rafael J. Wysocki" , Len Brown , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 773 Lines: 22 On Fri, Dec 16, 2016 at 8:20 PM, Darren Hart wrote: > On Tue, Dec 13, 2016 at 01:43:31AM +0200, Andy Shevchenko wrote: >> I have been told I have to send my comments here instead of our >> internal ML. I didn't fast enough to comment that during v5. So do it >> right now. >> > {arch/x86/include/asm => include/linux/platform_data/x86}/pmc_atom.h | 0 >> >> No, it's not a *platform data*. >> >> Other that that looks good to me. > > Where would you recommend instead? It needs a place to serve both acpi_lpss.c > and pmc_atom.c. The include/linux/platform_data/x86 location doesn't seem too > strange as it supports a "platform" driver in the sense that pmc_atom is a > platform driver. include/linux/x86 ? -- With Best Regards, Andy Shevchenko