From: KY Srinivasan <kys@microsoft.com>
To: Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <stephen@networkplumber.org>,
        Greg KH <gregkh@linuxfoundation.org>
CC: "olaf@aepfle.de" <olaf@aepfle.de>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "bjorn.helgaas@gmail.com" <bjorn.helgaas@gmail.com>,
        "apw@canonical.com" <apw@canonical.com>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        "leann.ogasawara@canonical.com" <leann.ogasawara@canonical.com>
Subject: RE: [PATCH 3/3] hv_netvsc: Implement VF matching based on serial
 numbers
Thread-Topic: [PATCH 3/3] hv_netvsc: Implement VF matching based on serial
 numbers
Thread-Index: AQHSUR217WryFwQHM0aSgrk15jlaWqD+NO0AgABUCDCAALFKAIAAtV0AgAAei4CAAAWGgIAAEUeAgAAD1wCAAAJrgIAAAyuAgAAIXYCAAB3RAIAAyPCAgAcBK4CAAAKCAIAABpgAgAGl5UCAAO/7AIAAN2Ag
Date: Fri, 16 Dec 2016 18:39:42 +0000
Message-ID: <DM5PR03MB249012322F220688723A1F1AA09C0@DM5PR03MB2490.namprd03.prod.outlook.com>
References: <BLUPR03MB1412E383295904172E85F647CA870@BLUPR03MB1412.namprd03.prod.outlook.com>
 <20161209122935.2bd0779e@xeon-e3>
 <BLUPR03MB1412A251ACF16A543F20E254CA870@BLUPR03MB1412.namprd03.prod.outlook.com>
 <20161209134510.22087f81@xeon-e3>
 <BLUPR03MB141254EC05D3BAF06A64B928CA870@BLUPR03MB1412.namprd03.prod.outlook.com>
 <20161209140509.1dd7cad2@xeon-e3>
 <BLUPR03MB141281091AFB66BE43A3E607CA870@BLUPR03MB1412.namprd03.prod.outlook.com>
 <20161209162148.44887938@xeon-e3> <20161210122059.GA21421@kroah.com>
 <BLUPR03MB1412267628B1ADA986619F21CA9A0@BLUPR03MB1412.namprd03.prod.outlook.com>
 <20161214232758.GA24234@kroah.com> <20161214155134.2015831f@xeon-e3>
 <DM5PR03MB2490150F68D47BA025335DA2A09C0@DM5PR03MB2490.namprd03.prod.outlook.com>
 <BLUPR03MB14124A002C8FA527DE7E5A9BCA9C0@BLUPR03MB1412.namprd03.prod.outlook.com>
In-Reply-To: <BLUPR03MB14124A002C8FA527DE7E5A9BCA9C0@BLUPR03MB1412.namprd03.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2016 18:39:42.1399
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1422
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uBGIvJqu023426
Content-Length: 3562
Lines: 88


> -----Original Message-----
> From: Haiyang Zhang
> Sent: Friday, December 16, 2016 7:21 AM
> To: KY Srinivasan <kys@microsoft.com>; Stephen Hemminger
> <stephen@networkplumber.org>; Greg KH <gregkh@linuxfoundation.org>
> Cc: olaf@aepfle.de; jasowang@redhat.com; linux-kernel@vger.kernel.org;
> bjorn.helgaas@gmail.com; apw@canonical.com;
> devel@linuxdriverproject.org; leann.ogasawara@canonical.com
> Subject: RE: [PATCH 3/3] hv_netvsc: Implement VF matching based on serial
> numbers
> 
> 
> 
> > -----Original Message-----
> > From: KY Srinivasan
> > Sent: Thursday, December 15, 2016 8:11 PM
> > To: Stephen Hemminger <stephen@networkplumber.org>; Greg KH
> > <gregkh@linuxfoundation.org>
> > Cc: olaf@aepfle.de; jasowang@redhat.com; linux-kernel@vger.kernel.org;
> > bjorn.helgaas@gmail.com; apw@canonical.com;
> devel@linuxdriverproject.org;
> > leann.ogasawara@canonical.com; Haiyang Zhang
> <haiyangz@microsoft.com>
> > Subject: RE: [PATCH 3/3] hv_netvsc: Implement VF matching based on
> > serial numbers
> >
> >
> >
> > > -----Original Message-----
> > > From: devel [mailto:driverdev-devel-bounces@linuxdriverproject.org]
> On
> > > Behalf Of Stephen Hemminger
> > > Sent: Wednesday, December 14, 2016 3:52 PM
> > > To: Greg KH <gregkh@linuxfoundation.org>
> > > Cc: olaf@aepfle.de; jasowang@redhat.com; linux-
> kernel@vger.kernel.org;
> > > bjorn.helgaas@gmail.com; apw@canonical.com;
> > > devel@linuxdriverproject.org; leann.ogasawara@canonical.com; Haiyang
> > > Zhang <haiyangz@microsoft.com>
> > > Subject: Re: [PATCH 3/3] hv_netvsc: Implement VF matching based on
> > serial
> > > numbers
> > >
> > > Normally, that would work but in this case we have one driver (netvsc)
> > > which is managing another driver which is unaware of Hyper-V or netvsc
> > > drivers existence.  The callback is happening in netvsc driver and it
> > > needs to say "hey I know that SR-IOV device, it is associated with my
> > > network device". This problem is how to know that N is associated with
> > > V? The V device has to be a network device, that is easy. But then it
> > > also has to be a PCI device, not to bad. But then the netvsc code
> > > is matching based on hyper-V only PCI bus metadata (the serial #).
> > >
> > > The Microsoft developers made the rational decision not to go
> > modifying
> > > all the possible SR-IOV network devices from Intel and Mellanox to add
> > > the functionality there. That would have been much worse.
> > >
> > > Maybe, rather than trying to do the management in the kernel it
> > > could have been done better in user space. Unfortunately, this would
> > > only move the problem.  The PCI-hyperv host driver could expose serial
> > > value through sysfs (with some pain). But the problem would be how
> > > to make a new API to  join the two V and N device.  Doing a private
> > > ioctl is worse than the notifier.
> >
> > All this has been discussed earlier in the thread. I think I have a
> > solution
> > to the problem:
> > The only PCI (non-VF) NIC that may be present in the VM is the emulated
> > NIC and
> > we know exactly the device ID and vendor ID of this NIC. Furthermore,
> > as a platform we are not going to be emulating additional NICs. So,
> > if the PCI NIC is not the emulated NIC, it must be a VF and we can
> > extract the
> > serial number.
> 
> How about direct pass-through NIC devices. Do they have vPCI serial
> number?
> And, the numbers should be different from VF NIC?

This may not have a valid serial number; but is still a descendent of vmbus.

K. Y  
> 
> Thanks,
> - Haiyang