Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758152AbcLPS6y (ORCPT ); Fri, 16 Dec 2016 13:58:54 -0500 Received: from forward3h.cmail.yandex.net ([87.250.230.18]:54424 "EHLO forward3h.cmail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbcLPS6r (ORCPT ); Fri, 16 Dec 2016 13:58:47 -0500 Authentication-Results: mxback11h.mail.yandex.net; dkim=pass header.i=@yandex.com.tr From: Ozgur Karatas Envelope-From: mueddib@yandex.com.tr To: Joe Perches , David Miller Cc: linux-kernel , netdev In-Reply-To: <1481913321.29291.89.camel@perches.com> References: <5194151481912505@web1g.yandex.ru> <1481913321.29291.89.camel@perches.com> Subject: Re: [PATCH 1/1] tools: net: bpf_dbg.c fixed keyboard typo MIME-Version: 1.0 Message-Id: <5466381481914723@web9h.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Fri, 16 Dec 2016 20:58:43 +0200 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 645 Lines: 23 16.12.2016, 20:35, "Joe Perches" : > On Fri, 2016-12-16 at 20:21 +0200, Ozgur Karatas wrote: >>  This patch fixed to keyboard typo, brackets not closed. >>  I think, it should be close to parenthes. > > No. > > Please compile and test your patches on your own system > before you send them. Also, checkpatch script give a error, it should not forget. $ ./scripts/checkpatch.pl --file --terse tools/net/bpf_dbg.c tools/net/bpf_dbg.c:1216: ERROR: do not use assignment in if condition After fix: $ ./scripts/checkpatch.pl --file --terse tools/net/bpf_dbg.c total: 0 errors, 6 warnings, 1395 lines checked Regards, ~Ozgur