Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758454AbcLPTIa (ORCPT ); Fri, 16 Dec 2016 14:08:30 -0500 Received: from mail-lf0-f43.google.com ([209.85.215.43]:34537 "EHLO mail-lf0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758287AbcLPTIW (ORCPT ); Fri, 16 Dec 2016 14:08:22 -0500 Subject: Re: [PATCH 1/1] tools: net: bpf_dbg.c fixed keyboard typo To: Ozgur Karatas , David Miller References: <5194151481912505@web1g.yandex.ru> Cc: linux-kernel , netdev From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <96578fd4-dd02-f39a-a252-c37aa714d3d0@cogentembedded.com> Date: Fri, 16 Dec 2016 22:08:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <5194151481912505@web1g.yandex.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 868 Lines: 33 Hello. On 12/16/2016 09:21 PM, Ozgur Karatas wrote: > This patch fixed to keyboard typo, brackets not closed. > I think, it should be close to parenthes. > > Signed-off-by: Ozgur Karatas > --- > tools/net/bpf_dbg.c | 2 +- > 1 files changed, 1 insertion(+), 1 deletions(-) > > diff --git a/tools/net/bpf_dbg.c b/tools/net/bpf_dbg.c > index 4f254bc..f715f46 100644 > --- a/tools/net/bpf_dbg.c > +++ b/tools/net/bpf_dbg.c > @@ -1213,7 +1213,7 @@ static int cmd_disassemble(char *line_string) > > if (!bpf_prog_loaded()) > return CMD_ERR; > - if (strlen(line_string) > 0 && > + if (strlen(line_string) > 0 &&) Have tried to you compile that? :-/ > (line = strtoul(line_string, NULL, 10)) < bpf_prog_len) I think the code was correct before your patch... > single_line = true; > if (single_line) MBR, Sergei